Utilize Warden Redirect #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2024
|
Please rebase |
|
Hi @strzibny, the tests on this branch are still failing for some reason. I will let you know when I get them resolved. |
|
Okay, please rebase to master. I'll do more testing of this after. After that I could cut a new release with the changes. |
|
OK, I have rebased. It is ready for you. |
strouptl
force-pushed
the
warden_redirect
branch
2 times, most recently
from
6687f16 to
4a4da49
Compare
|
Please rebase again |
…tications directly to OTP Credentials controller rather than logging in; delete Sessions hook with overwritten logout/login "create_session" method (no longer needed);
…ller; - Move challenge, recovery, and resource variables to filters for easier reference; - Unnest "challenge" and "recovery" fields in form params for consistency between show and update actions;
…entering user token when OTP is enabled;
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes the native Warden "redirect!" method to redirect users from the sign in form to the OTP challenge without signing in. Benefits of this approach include:
NOTE: tests are failing, as the above PR's must be merged first.