Switch test suite to default Rack Test #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… download URL and content directly via default :rack_test functionality; remove custom driver and download helper (no longer needed);
…e already the defaults); remove cuprite from gemspec;
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite utilizes the cuprite driver, which causes compatibility issues with the Warden redirect solution in PR #80 (produces a "Chrome data error" when querying the current_url). In addition, the current testing approach does not test the actual content of the recovery codes download (only that something was downloaded).
This PR switches the test suite to the default rack_test driver, which resolves the test failures in PR #80, adds tests for the actual content of the recovery codes download, and simplifies the codebase by removing the custom Capybara coniguration and DowloadHelper module.