Refresh Credentials Hook #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2024
Merged
strouptl
force-pushed
the
refresh_credentials
branch
from
f4a9b9c to
d1c55d4
Compare
|
We'll need a rebase |
…d_at value; - Switch to warden session scope for simplicity; - Move requiring of "hooks/refreshable" to main devise-otp.rb file;
- Remove "scoped" verbiage from session properties (since scope is now applied via warden); - Remove comment regarding cookie scope for otp_refresh_property (now applied via warden);
strouptl
force-pushed
the
refresh_credentials
branch
from
d1c55d4 to
de7683e
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the refresh_credentials functionality to a dedicated hook which takes place only after a complete and successful authentication (rather than applying it, and then logging out within the create_otp_session method).
While it does not fix any specific issues, it relieves some of the burden on the create_otp_session, which prepares the way for additional optimizations (pending).