Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): Update pages.mdx and plugins.mdx #1545

Merged
merged 11 commits into from
Feb 22, 2024
Merged

i18n(fr): Update pages.mdx and plugins.mdx #1545

merged 11 commits into from
Feb 22, 2024

Conversation

thomasbnt
Copy link
Member

Description

Update french documentation for pages.mdx and plugins.mdx

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 04f01c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 22, 2024 8:10pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 22, 2024
dreyfus92
dreyfus92 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @thomasbnt, LGTM ✅

delucis
delucis reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @thomasbnt! Noticed one small detail.

docs/src/content/docs/fr/guides/pages.mdx Outdated Show resolved Hide resolved
HiDeoo
HiDeoo requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

Left a few suggestions but nothing major, mostly consistency changes and a missing line break.

docs/src/content/docs/fr/guides/pages.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/pages.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/pages.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/pages.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/pages.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/resources/plugins.mdx Outdated Show resolved Hide resolved
thomasbnt and others added 9 commits February 22, 2024 21:04
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/resources/plugins.mdx
d241016 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @delucis
Update docs/src/content/docs/fr/guides/pages.mdx
f7ebcef 
Co-authored-by: Chris Swithinbank <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/pages.mdx
7832821 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/pages.mdx
62ff12a 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/pages.mdx
01ca377 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/pages.mdx
327f841 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/pages.mdx
2568aed 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/resources/plugins.mdx
32d311c 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt
Merge branch 'main' into i18n-fr-update-pages-and-plugins
04f01c0
@thomasbnt
Copy link
Member Author

Hello and thanks for your reviews @HiDeoo and @delucis !

HiDeoo
HiDeoo approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update and everyone for the reviews 🌟

@HiDeoo HiDeoo merged commit e8e3b7a into withastro:main Feb 22, 2024
9 checks passed
log101 pushed a commit to log101/starlight that referenced this pull request Feb 23, 2024
@thomasbnt @delucis
@HiDeoo @McFlyPartages @dreyfus92 @log101
i18n(fr): Update pages.mdx and plugins.mdx (withastro#1545)
04c70bb 
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: HiDeoo <[email protected]>
Co-authored-by: McFlyPartages <[email protected]>
Co-authored-by: Paul Valladares <[email protected]>
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 23, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree
23f6727 
* main: (21 commits)
  i18n(ja): Update plugins.mdx (withastro#1550)
  [ci] format
  docs: Added Portuguese (pt-PT) language (withastro#1503)
  [ci] format
  i18n(fr): Update pages.mdx and plugins.mdx (withastro#1545)
  i18n(hi): update outdated pages (withastro#1539)
  i18n(es): Update getting-started.mdx (withastro#1531)
  [ci] format
  i18n(es): add "pages" page (withastro#1537)
  i18n(hi): add `customization.mdx` (withastro#1538)
  Update Vietnamese UI translations (withastro#1544)
  [ci] format
  [ci] release (withastro#1540)
  Improve DX for `sidebar` prop in `<StarlightPage>` and document it (withastro#1534)
  i18n(zh-tw): add Traditional Chinese UI translations (withastro#1504)
  Export `StarlightPageProps` type (withastro#1527)
  [ci] format
  Add new starlight-ghostcms to Community plugins list (withastro#1536)
  docs: Add more plugins & tools (withastro#1528)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

@dreyfus92 dreyfus92 dreyfus92 approved these changes

@McFlyPartages McFlyPartages McFlyPartages approved these changes

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomasbnt @delucis @HiDeoo @McFlyPartages @dreyfus92