Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(hi): update outdated pages #1539

Merged
merged 5 commits into from
Feb 22, 2024
Merged

i18n(hi): update outdated pages #1539

merged 5 commits into from
Feb 22, 2024

Conversation

at-the-vr
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6d90889

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 22, 2024 6:44pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 20, 2024
delucis
delucis reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates @at-the-vr! Spotted a couple of small details but otherwise this looks great 🌟

docs/src/content/docs/hi/getting-started.mdx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that much of the content deleted here was moved to the new “Pages” guide, so can probably be a good reference point when that gets translated.

docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
delucis
delucis approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes @at-the-vr — looks good to go ✨

@delucis delucis merged commit 7a3c5c1 into withastro:main Feb 22, 2024
9 checks passed
log101 pushed a commit to log101/starlight that referenced this pull request Feb 23, 2024
@at-the-vr @delucis @log101
i18n(hi): update outdated pages (withastro#1539)
fb23c3b 
Co-authored-by: Chris Swithinbank <[email protected]>
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 23, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree
23f6727 
* main: (21 commits)
  i18n(ja): Update plugins.mdx (withastro#1550)
  [ci] format
  docs: Added Portuguese (pt-PT) language (withastro#1503)
  [ci] format
  i18n(fr): Update pages.mdx and plugins.mdx (withastro#1545)
  i18n(hi): update outdated pages (withastro#1539)
  i18n(es): Update getting-started.mdx (withastro#1531)
  [ci] format
  i18n(es): add "pages" page (withastro#1537)
  i18n(hi): add `customization.mdx` (withastro#1538)
  Update Vietnamese UI translations (withastro#1544)
  [ci] format
  [ci] release (withastro#1540)
  Improve DX for `sidebar` prop in `<StarlightPage>` and document it (withastro#1534)
  i18n(zh-tw): add Traditional Chinese UI translations (withastro#1504)
  Export `StarlightPageProps` type (withastro#1527)
  [ci] format
  Add new starlight-ghostcms to Community plugins list (withastro#1536)
  docs: Add more plugins & tools (withastro#1528)
  [ci] format
  ...
@at-the-vr at-the-vr deleted the atv/i18n/hi/update branch May 22, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@at-the-vr @delucis