Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(es): add "pages" page #1537

Merged
merged 9 commits into from
Feb 22, 2024
Merged

i18n(es): add "pages" page #1537

merged 9 commits into from
Feb 22, 2024

Conversation

kevinzunigacuellar
Copy link
Member

Description

  • Adds new guides/pages/ in Spanish

Copy link

changeset-bot bot commented Feb 20, 2024

⚠️ No Changeset found

Latest commit: 03f2b07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 22, 2024 6:36pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) Feb 22, 2024 6:36pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 20, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Feb 20, 2024

size-limit report 📦

Path Size
/index.html 5.23 KB (+0.02% 🔺)
/_astro/*.js 21.54 KB (-0.02% 🔽)
/_astro/*.css 13.13 KB (0%)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link checker strikes again!

Error: 5 [ERROR] ✗ Found 9 invalid links in 1 file.
15:35:05 ▶ es/guides/pages/
15:35:05   ├─ /reference/frontmatter/ - inconsistent locale
15:35:05   ├─ /reference/frontmatter/ - inconsistent locale
15:35:05   ├─ /reference/frontmatter/#title-required - inconsistent locale
15:35:05   ├─ /reference/frontmatter/#slug - inconsistent locale
15:35:05   ├─ /reference/frontmatter/#editurl - inconsistent locale
15:35:05   ├─ /reference/frontmatter/#sidebar - inconsistent locale
15:35:05   ├─ /reference/configuration/#sidebar - inconsistent locale
15:35:05   ├─ /reference/frontmatter/#template - inconsistent locale
15:35:05   └─ /guides/i18n/#fallback-content - inconsistent locale

Looks like these all need /es/ in front. (#title-required might also need updating for the translation?)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the translation and updates @kevinzunigacuellar 💖

@delucis delucis merged commit 533af9f into main Feb 22, 2024
9 checks passed
@delucis delucis deleted the es/pages branch February 22, 2024 18:37
log101 pushed a commit to log101/starlight that referenced this pull request Feb 23, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 23, 2024
* main: (21 commits)
  i18n(ja): Update plugins.mdx (withastro#1550)
  [ci] format
  docs: Added Portuguese (pt-PT) language (withastro#1503)
  [ci] format
  i18n(fr): Update pages.mdx and plugins.mdx (withastro#1545)
  i18n(hi): update outdated pages (withastro#1539)
  i18n(es): Update getting-started.mdx (withastro#1531)
  [ci] format
  i18n(es): add "pages" page (withastro#1537)
  i18n(hi): add `customization.mdx` (withastro#1538)
  Update Vietnamese UI translations (withastro#1544)
  [ci] format
  [ci] release (withastro#1540)
  Improve DX for `sidebar` prop in `<StarlightPage>` and document it (withastro#1534)
  i18n(zh-tw): add Traditional Chinese UI translations (withastro#1504)
  Export `StarlightPageProps` type (withastro#1527)
  [ci] format
  Add new starlight-ghostcms to Community plugins list (withastro#1536)
  docs: Add more plugins & tools (withastro#1528)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants