-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS guide: Use new URL()
instead of template literal
#8632
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR Eva 🙌 and thank you for covering all locales as well
new URL()
instead of template literalnew URL()
instead of template literal [i18nIgnore]
Hi @evadecker , thanks so much for providing this! Because of our translation status tracking, however, we do ask that PRs only be submitted in one language, then we let the translators catch up. Some of these pages might be out of date translations, some not. Someone might be working on updating a page at the moment! So, it's always easiest for us to only accept English versions of fixes, even when it looks like it should just be a simple fix across the board. When you remove the other language files, we can get this merged! 🙌 |
new URL()
instead of template literal [i18nIgnore]new URL()
instead of template literal
No worries, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Signed-off-by: Thomas Bonnet <[email protected]>
* i18n(fr): Update guides/astro-db from #8478 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/backend from #8450 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/backend/google-firebase from #8422 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/apostrophecms from #8480 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/builderio from #8259 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/directus from #8647 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/ghost from #8518 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/statamic from #7119 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/content-collections from #8447 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/data-fetching from #8210 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/cloudflare from #8421 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/netlify from #8233 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/render from #8233 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos) Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/environment-variables from #8533 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/environment-variables from #8611 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/images from #8447 #8646 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide from #8575 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/cloudflare from #8211 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/lit from #8270 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps) Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/preact from #8644 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/react from #8038 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/vue from #8295 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/markdown-content from #7218 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/markdown-content from #8167 #8239 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/middleware from #8572 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/prefetch from #8246 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/routing from #8466 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/rss from #8632 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/testing from #8369 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/view-transitions from #8646 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix typo in routing.mdx Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix links ? Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <[email protected]> * Update src/content/docs/fr/guides/environment-variables.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/lit.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/vue.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/markdown-content.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/middleware.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * i18n(fr): Fix links Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update `tutorial/6-islands` because CI links err Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <[email protected]> --------- Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: pioupia <[email protected]> Co-authored-by: Yan <[email protected]>
Description (required)
The RSS guide currently uses a template literal to concatenate
rss.xml
andAstro.site
. This works without issue when the site is built, but it raises an ESLint warning:This PR updates the guide to recommend the safer
URL()
constructor to create the link to therss.xml
file.