-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update astro-db.mdx #8478
Update astro-db.mdx #8478
Conversation
add some missing details to make the tutorial more fluid. if you follow the tutorial, at this point, your comment table has author and content columns. The seed script is going to fail because it's missing data in the author table and the Comment table does not have body column
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wlai-lp ! Thank you for pointing this out! However, these two examples are not meant to follow each other. This is not a tutorial where you complete every step in order, but just a very minimal example of each process. In fact, none of the examples necessarily work with each other, so that's entirely expected!
I do think your changes are helpful though, for people who are treating it like a tutorial! I will just make a minor change as we like to try to be representative of our global audience when adding new names in our code examples. Thank you again for this contribution, and I am happy to welcome you to Team Docs! 🥳
NOTE: Not merging until we figure out why the deploy build is failing, just to be safe! 😄 (Probably not related to this PR, but want to make sure our builds are working first before merging new PRs) |
Signed-off-by: Thomas Bonnet <[email protected]>
* i18n(fr): Update guides/astro-db from #8478 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/backend from #8450 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/backend/google-firebase from #8422 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/apostrophecms from #8480 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/builderio from #8259 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/directus from #8647 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/ghost from #8518 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/statamic from #7119 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/content-collections from #8447 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/data-fetching from #8210 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/cloudflare from #8421 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/netlify from #8233 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/render from #8233 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos) Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/environment-variables from #8533 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/environment-variables from #8611 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/images from #8447 #8646 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide from #8575 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/cloudflare from #8211 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/lit from #8270 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps) Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/preact from #8644 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/react from #8038 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/vue from #8295 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/markdown-content from #7218 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/markdown-content from #8167 #8239 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/middleware from #8572 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/prefetch from #8246 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/routing from #8466 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/rss from #8632 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/testing from #8369 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/view-transitions from #8646 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix typo in routing.mdx Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix links ? Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <[email protected]> * Update src/content/docs/fr/guides/environment-variables.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/lit.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/vue.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/markdown-content.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/middleware.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * i18n(fr): Fix links Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update `tutorial/6-islands` because CI links err Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <[email protected]> --------- Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: pioupia <[email protected]> Co-authored-by: Yan <[email protected]>
Description (required)
add some missing details to make the tutorial more fluid. if you follow the tutorial, at this point, your comment table has author and content columns. The seed script is going to fail because it's missing data in the author table and the Comment table does not have body column
Related issues & labels (optional)