-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added caution element to the anchor section. #8466
Conversation
This will help users understand that Astro does not manage anchor elements
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR @nicogutz 🔥🔥. LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this helpful addition, @nicogutz ! The information is absolutely great to have here! I've just changed the formatting to be more consistent with Astro Docs style!
I think the example below serves the purpose of demonstrating that base
needs to be taken into account when creating URLs. Given that this is a very introductory section, and there are a variety of ways that handling the base can be accomplished, we prefer to keep the documentation simple and illustrative here.
Thank you again for this very helpful contribution, and welcome to Team Docs! 🥳
<p>Read more <a href="/about/">about</a> Astro!</p> | ||
``` | ||
|
||
:::caution | ||
Changing the [base](/en/reference/configuration-reference/#base) configuration option does not change the `href` of `<a>` elements. This has to be done manually using `Astro.url` or `import.meta.env.BASE_URL` on each element. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>Read more <a href="/about/">about</a> Astro!</p> | |
``` | |
:::caution | |
Changing the [base](/en/reference/configuration-reference/#base) configuration option does not change the `href` of `<a>` elements. This has to be done manually using `Astro.url` or `import.meta.env.BASE_URL` on each element. | |
::: | |
<p>Read more <a href="/about/">about</a> Astro!</p> | |
<!-- With `base: "/docs"` configured --> | |
<p>Learn more in our <a href="/docs/reference/">reference</a> section!</p> | |
``` |
We only use caution very rarely, for things like security issues. In general, we prefer to document "how something works" properly in the first place, not add notes on like we forgot to say something. 😅
When multiple options are possible, we usually extend the code block to show more examples. I think this is helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only use caution very rarely, for things like security issues. In general, we prefer to document "how something works" properly in the first place, not add notes on like we forgot to say something. 😅
I will keep that in mind for next time 😃 , nevertheless, the example shows the opposite of what happens, see withastro/astro#11159. The base
never changes the href
.
This is why I thought it was important to explicitly indicate that the anchors are not changed with the base config parameter. A user coming from other frameworks might assume that since the assets are changed by the config, then the anchors must be automatically changed as well.
Signed-off-by: Thomas Bonnet <[email protected]>
* i18n(fr): Update guides/astro-db from #8478 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/backend from #8450 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/backend/google-firebase from #8422 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/apostrophecms from #8480 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/builderio from #8259 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/directus from #8647 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/ghost from #8518 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/cms/statamic from #7119 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/content-collections from #8447 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/data-fetching from #8210 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/cloudflare from #8421 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/netlify from #8233 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/render from #8233 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos) Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/environment-variables from #8533 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/environment-variables from #8611 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/images from #8447 #8646 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide from #8575 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/cloudflare from #8211 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/lit from #8270 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps) Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/preact from #8644 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/react from #8038 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/integrations-guide/vue from #8295 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/markdown-content from #7218 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/markdown-content from #8167 #8239 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/middleware from #8572 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/prefetch from #8246 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/routing from #8466 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/rss from #8632 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/testing from #8369 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update guides/view-transitions from #8646 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix typo in routing.mdx Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix links ? Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <[email protected]> * Update src/content/docs/fr/guides/environment-variables.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/lit.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/vue.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/markdown-content.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/middleware.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <[email protected]> * i18n(fr): Fix links Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update `tutorial/6-islands` because CI links err Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <[email protected]> --------- Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: pioupia <[email protected]> Co-authored-by: Yan <[email protected]>
This will help users understand that Astro does not manage anchor elements
Description (required)
When building with a base config other than
/
, none of the hrefs on anchor elements are changed. This is never explicitly mentioned in the documentation. I added a caution element to inform users that they have to change it manually and gave them two main options to do so.Related issues & labels (optional)