-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] Add tab component to recipes and deploy.mdx
#5305
[i18nIgnore] Add tab component to recipes and deploy.mdx
#5305
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
deploy.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Did you update these for every available language (just making sure).
Also, the CI seems to fail on links / an unclosed tag, can you check that
As far as I can tell I updated these for every available language. And, the CI on check links is just a fluke and should work fine if the test is rerun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the changes and found all of the changes in deploy.mdx
files & es/recipes/external-links
return a MDXError
I found only fix being just formatting the PackageManagerTabs Snippet similar as any of the add-yaml-support.mdx or any file that uses PackageManagerTabs (en/install/auto
for example) changes
```bash | ||
npm install --global netlify-cli | ||
``` | ||
<PackageManagerTabs> | ||
<Fragment slot="npm"> | ||
```shell | ||
npm install --global netlify-cli | ||
``` | ||
</Fragment> | ||
<Fragment slot="pnpm"> | ||
```shell | ||
pnpm add --global netlify-cli | ||
``` | ||
</Fragment> | ||
<Fragment slot="yarn"> | ||
```shell | ||
yarn global add netlify-cli | ||
``` | ||
</Fragment> | ||
</PackageManagerTabs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes involving ordered list currently are not looking right.
As an example: https://deploy-preview-5305--astro-docs-2.netlify.app/en/guides/deploy/
The CLI command area should be a child of the ordered list, currently it's being rendered as a sibling element between two ordered lists.
You can add indentation to make it render as a child:
-<PackageManagerTabs>
- <Fragment slot="npm">
- ```shell
- npm install --global netlify-cli
- ```
- </Fragment>
- <Fragment slot="pnpm">
- ```shell
- pnpm add --global netlify-cli
- ```
- </Fragment>
- <Fragment slot="yarn">
- ```shell
- yarn global add netlify-cli
- ```
- </Fragment>
- </PackageManagerTabs>
+ <PackageManagerTabs>
+ <Fragment slot="npm">
+ ```shell
+ npm install --global netlify-cli
+ ```
+ </Fragment>
+ <Fragment slot="pnpm">
+ ```shell
+ pnpm add --global netlify-cli
+ ```
+ </Fragment>
+ <Fragment slot="yarn">
+ ```shell
+ yarn global add netlify-cli
+ ```
+ </Fragment>
+ </PackageManagerTabs>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is well put, I will stick with these as well. Thanks @Genteure 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jacobthesheep! 🎉
It looks like there are issues with the indenting of tabs in lists.
Once corrected, they should be part of the list indent.
I've suggested one example of correct indenting. You can view the indenting in the Netlify deploy preview once you've committed your changes. Once you have updated all the changes, we can take another look!
Co-authored-by: Atharva Pise <[email protected]>
Co-authored-by: Atharva Pise <[email protected]>
Should be fixed now! |
Hey @jacobthesheep ! The indenting looks good on all the pages except the "external links" one. Do you mind taking another look at that, and then I'm happy to get this one merged! 🚀 |
Got it! |
Looking great now! Let's jump this one into the merge queue! 🚋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding to Merge Queue
Update file with PR #5217 #5305 #5572 Co-authored-by: Yan Thomas <[email protected]>
Update file with PR #5217 #5305 #5572 Co-authored-by: Yan Thomas <[email protected]>
* update add-yaml-support #4666, #5305. #5846, #8167 * translate commenst --------- Co-authored-by: Yan <[email protected]>
Description (required)
Add a tab component to the remaining recipe pages and
deploy.mdx
.Related issues & labels (optional)