Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18nIgnore] remove most ssr page link anchors #5217

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

sarah11918
Copy link
Member

Description (required)

Future-proofing SSR page links by removing anchors. This will allow the page content to be refreshed and headings to be updated for the new on-demand rendered/pre-rendered phrasing without causing a nightmare throughout the site.

Related issues & labels (optional)

@sarah11918 sarah11918 added the typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. label Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit bd9ac15
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/653c0fdd3734a400086483c4
😎 Deploy Preview https://deploy-preview-5217--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 27, 2023
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanthomasdev yanthomasdev merged commit b5f2233 into main Oct 28, 2023
10 checks passed
@yanthomasdev yanthomasdev deleted the more-ssr-links branch October 28, 2023 01:37
yanthomasdev added a commit that referenced this pull request Dec 8, 2023
Update file with PR #5217 #5305 #5572

Co-authored-by: Yan Thomas <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Update file with PR #5217 #5305 #5572

Co-authored-by: Yan Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants