Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: experimental i18n routing #8974

Merged
merged 36 commits into from
Nov 8, 2023
Merged

feat: experimental i18n routing #8974

merged 36 commits into from
Nov 8, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Nov 1, 2023 •
edited
Loading

Changes

Experimental i18n routing.

RFC: withastro/roadmap#734

Testing

New tests added. The existing tests not related to i18n routing should pass because this feature is opt-in.

Docs

/cc @withastro/maintainers-docs for feedback!

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 78bf6bd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 1, 2023
@ematipico
Copy link
Member Author

!preview i18n-routing

@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Nov 1, 2023
github-actions[bot]
github-actions bot previously requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Snapshots have been released for the following packages:

  • astro@experimental--i18n-routing
Publish Log 
🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--i18n-routing tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/prefetch
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info astro is being published because our local version (0.0.0-i18n-routing-20231101144500) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.0.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 3.0.0 is already published on npm
🦋  warn create-astro is not being published because version 4.5.0 is already published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.3.1 is already published on npm
🦋  warn @astrojs/lit is not being published because version 3.0.2 is already published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.7.1 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 1.1.3 is already published on npm
🦋  warn @astrojs/node is not being published because version 6.0.3 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.0.2 is already published on npm
🦋  warn @astrojs/preact is not being published because version 3.0.1 is already published on npm
🦋  warn @astrojs/prefetch is not being published because version 0.4.1 is already published on npm
🦋  warn @astrojs/react is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.0.3 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 3.0.2 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 4.0.3 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.0.2 is already published on npm
🦋  warn @astrojs/vercel is not being published because version 5.1.0 is already published on npm
🦋  warn @astrojs/vue is not being published because version 3.0.3 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.2.1 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 3.3.0 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.1 is already published on npm
🦋  info Publishing "astro" at "0.0.0-i18n-routing-20231101144500"
🦋  success packages published successfully:
🦋  [email protected]
🦋  Creating git tag...
🦋  New tag:  [email protected]
Build Log 

> [email protected] build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro
• Running build in 26 packages
• Remote caching enabled
::group::@astrojs/telemetry:build
cache hit, suppressing logs 470a5e5395d8d67a
::endgroup::
::group::@astrojs/internal-helpers:build
cache hit, suppressing logs 5189e4765f9441aa
::endgroup::
::group::@astrojs/prism:build
cache hit, suppressing logs d2dcda1a046ff7cf
::endgroup::
::group::@astrojs/markdown-remark:build
cache hit, suppressing logs fafbc9f1673d75a8
::endgroup::
::group::create-astro:build
cache miss, executing 895cd7a62cb990ee

> [email protected] build /home/runner/work/astro/astro/packages/create-astro
> astro-scripts build "src/index.ts" --bundle && tsc

::endgroup::
::group::astro:build
cache miss, executing 05417f7f03416691

> [email protected] build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild


> [email protected] prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"


> [email protected] postbuild /home/runner/work/astro/astro/packages/astro
> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm"

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing 21332a0d65d8e4ca

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing 73b1097380078358

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/lit:build
cache miss, executing 3eb07ed0e9065d9d

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/lit
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing df5b1358ee831889

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/timer:build
cache miss, executing 361a312fcc74713c

> @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing 90f8bc8ebc39bff0

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing 267713404d23a4f8

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing 98c1d8a4952e1634

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/node:build
cache miss, executing 1fbb67dc3571f1a8

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/node
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing 1da16c8f3ab1396a

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/prefetch:build
cache miss, executing 6ec3b95e8fd3fcce

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/prefetch
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing 5326dbfcd20a5e6a

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing 6daccea7834504b0

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing 83d2fa09171a29b6

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@astrojs/vercel:build
cache miss, executing 328afd53a10de80d

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vercel
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing 7071811b9c5a6f18

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing 7c339aac237dd1af

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 097b2c5ca36188d5

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    24 successful, 24 total
Cached:    4 cached, 24 total
  Time:    1m26.301s

@ematipico ematipico mentioned this pull request Nov 2, 2023
Merged
sarah11918
sarah11918 reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've left some feedback on the docs and error messages here! If there's something that I should have looked at but didn't, then please let me know!

ALSO: I may come back and update these as I read the docs PR. I happened to do this page first, as it was less and more concise content. I may read/learn something in the larger guide that either clears some things up for me here, or changes my opinion on some things. So, if you're thinking, "Didn't she read the guide??" welll, no, not yet! Gotta start somewhere!

packages/astro/src/core/errors/errors-data.ts Outdated Show resolved Hide resolved
packages/astro/src/@types/astro.ts Show resolved Hide resolved
packages/astro/src/@types/astro.ts Outdated Show resolved Hide resolved
packages/astro/src/@types/astro.ts Outdated Show resolved Hide resolved
packages/astro/src/@types/astro.ts Outdated Show resolved Hide resolved
packages/astro/src/@types/astro.ts Outdated Show resolved Hide resolved
packages/astro/src/@types/astro.ts Outdated Show resolved Hide resolved
@ematipico ematipico mentioned this pull request Nov 3, 2023
Merged
@ematipico ematipico marked this pull request as ready for review November 6, 2023 15:06
@ematipico
Copy link
Member Author

@sarah11918

@ematipico ematipico force-pushed the feat/i18n-routing branch 2 times, most recently from 0d09b79 to 185a1aa Compare November 6, 2023 15:22
sarah11918
sarah11918 reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last two comments from me on the changeset!

Please /ptal me if you need me to come back and look again! I'll be in the Docs PR until further notice!

.changeset/rude-lizards-scream.md Outdated Show resolved Hide resolved
.changeset/rude-lizards-scream.md Outdated Show resolved Hide resolved
sarah11918
sarah11918 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changeset! 🥳

@ematipico ematipico force-pushed the feat/i18n-routing branch 2 times, most recently from 01e0a35 to 5c1e793 Compare November 8, 2023 14:32
ematipico and others added 22 commits November 8, 2023 14:50
@ematipico
add changeset
a5c7cf7
@ematipico @sarah11918
Update packages/astro/src/@types/astro.ts
40678fa 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico @sarah11918
Apply suggestions from code review
b2ea981 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico @sarah11918
Update packages/astro/src/@types/astro.ts
6a0ddf5 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico @sarah11918
chore(i18n): reworked fallback, docs, types and validation (#8995)
6355160 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico
chore: make normalize path the default (#9004)
b3730ab
@ematipico
refactor(i18n): compute preferred locales lazily (#8997)
486dcb3
@ematipico
fix(i18n): consider routingStrategy when computing the URLs (#9008)
ed87c35
@ematipico
add changelog
1cb1b4a
@ematipico @sarah11918
Update packages/astro/src/@types/astro.ts
640ee19 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico @sarah11918
Update packages/astro/src/@types/astro.ts
b70ab6e 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico @sarah11918
Update packages/astro/src/core/errors/errors-data.ts
63cb660 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico
chore: add suggestions from Sarah
8781c00
@ematipico
fix(i18n): redirect the index when prefix-always is enabled (#9006)
851c7c8
@ematipico @sarah11918
Apply suggestions from code review
9f35447 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico @sarah11918
Update .changeset/rude-lizards-scream.md
7607ef2 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico
chore: remove example
66d642e
@ematipico
chore: update correct file system
51d4777
@ematipico @sarah11918
Update .changeset/rude-lizards-scream.md
38f1214 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico
fix(i18n): better filtering and search for preferred locales (#9019)
29da1ca
@ematipico @sarah11918
Update .changeset/rude-lizards-scream.md
d40da19 
Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico
chore: apply suggestions
78bf6bd
@ematipico ematipico merged commit 143bacf into main Nov 8, 2023
@ematipico ematipico deleted the feat/i18n-routing branch November 8, 2023 15:45
@astrobot-houston astrobot-houston mentioned this pull request Nov 8, 2023
Merged
@TheOtterlord TheOtterlord mentioned this pull request Nov 9, 2023
Merged
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
@ematipico @florian-lefebvre
@martrapp @ElianCodes @sarah11918 @natemoo-re
feat: experimental i18n routing (#8974)
dbc8c8a 
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Martin Trapp <[email protected]>
Co-authored-by: Elian ☕️ <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre left review comments

@bluwy bluwy bluwy approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ematipico @matthewp @sarah11918 @bluwy @florian-lefebvre