Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(i18n): make normalizePath to default to true #9004

Merged
merged 1 commit into from
Nov 6, 2023
Merged

refactor(i18n): make normalizePath to default to true #9004

merged 1 commit into from
Nov 6, 2023

Conversation

ematipico
Copy link
Member

Changes

From API bash session, we agreed that it makes sense to have the option normalizePath set to true as a default value because that's what users would want most of the times.

Testing

Updated the tests

Docs

Update the examples

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2023

⚠️ No Changeset found

Latest commit: 6320cae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 6, 2023
@ematipico ematipico added the pr: docs A PR that includes documentation for review label Nov 6, 2023
@ematipico ematipico changed the title feat(i18n): first draft of configuration (#8607) refactor(i18n): make normalizePath to default to true Nov 6, 2023
sarah11918
sarah11918 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ematipico ematipico merged commit 06e86f9 into feat/i18n-routing Nov 6, 2023
@ematipico ematipico deleted the feat/normalize-path-true branch November 6, 2023 09:52
ematipico added a commit that referenced this pull request Nov 6, 2023
@ematipico
chore: make normalize path the default (#9004)
f54e508
ematipico added a commit that referenced this pull request Nov 6, 2023
@ematipico
chore: make normalize path the default (#9004)
530f570
ematipico added a commit that referenced this pull request Nov 7, 2023
@ematipico
chore: make normalize path the default (#9004)
fe80e37
ematipico added a commit that referenced this pull request Nov 8, 2023
@ematipico
chore: make normalize path the default (#9004)
15742fd
ematipico added a commit that referenced this pull request Nov 8, 2023
@ematipico
chore: make normalize path the default (#9004)
c0e86bd
ematipico added a commit that referenced this pull request Nov 8, 2023
@ematipico
chore: make normalize path the default (#9004)
6695f73
ematipico added a commit that referenced this pull request Nov 8, 2023
@ematipico
chore: make normalize path the default (#9004)
b3730ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @sarah11918 @bluwy