-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dnm] chore: remove Node.js 4, add Node.js 10 #80
[dnm] chore: remove Node.js 4, add Node.js 10 #80
Conversation
See the following because of the failing Windows build: nodejs/node#20297 |
@evilebottnawi should we add v10 anyways? |
Looks we catch node 10.0.0 bug 😆 |
@ev1stensberg yep, we need add 10.0.0 in all webpack/webpack-contrib repos |
Blocker nodejs/node#20297. Using webpack and watch mode on nodejs 10.0.0 can't works as expected 😞 |
The watch mode is used on CI? Shouldn't this not be the case normally? |
@DanielRuf here tests for watch systems |
Ah ok, makes definitely sense 😃 Sorry. |
@DanielRuf we need restart CI, node 10.1.0 release |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
======================================
Coverage 95.5% 95.5%
======================================
Files 3 3
Lines 356 356
Branches 97 97
======================================
Hits 340 340
Misses 16 16 Continue to review full report at Codecov.
|
Seems it is not yet available on Appveyor. Should I ping them? |
/cc @ooflorent can you restart CI, looks i don't have access |
I don’t have enough privilege on appveyor. Close/reopen works best. |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
======================================
Coverage 95.5% 95.5%
======================================
Files 3 3
Lines 356 356
Branches 97 97
======================================
Hits 340 340
Misses 16 16 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
======================================
Coverage 95.5% 95.5%
======================================
Files 3 3
Lines 356 356
Branches 97 97
======================================
Hits 340 340
Misses 16 16 Continue to review full report at Codecov.
|
Thanks |
Closes #79