chore: add Node.js 8 and 10

[DanielRuf]

No description provided.

[codecov-io]

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #100   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         194    194           
  Branches       33     33           
=====================================
  Hits          194    194

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532cf88...f8978f2. Read the comment docs.

[iamkun]

@DanielRuf what's this pr for?

[DanielRuf]

@DanielRuf what's this pr for?

This PR is to add Node.js 8 and 10 to the Travis builds so we can run the unit tests on these versions too and catch Node.js 8 and 10 bugs earlier and make sure that also these stable and LTS releases are supported.

[DanielRuf]

https://travis-ci.org/xx45/dayjs/builds/374739282

[iamkun]

Yes, I know what's this config used for.

I'm not sure if we need it. Actually we have all these tests in the past. You could see a travis-deploy-once used in the .travis.yml at that time.

Just wondering if our unit test runs perfectly on Node6, a lower node version, dose that mean it shoud be good on 8 and 10?

Plus, will this expand the total CI process time?

[DanielRuf]

Plus, will this expand the total CI process time

No, not in general. These do normally use a test matrix.

I'm not sure if we need it. Actually we have all these tests in the past. You could see a travis-deploy-once used in the .travis.yml at that time.

Why not? There can be always changes in Node.js which affect libraries.

You could see a travis-deploy-once used in the .travis.yml at that time.

You can constrain it to a specific Node.js version / test.

[DanielRuf]

Regarding different Node.js versions and testing: webpack/watchpack#80 (comment)

Also older versions (4 is EOL) often break and dependencies are often not compatible anymore (eg puppeteer requires Node.js 6+).

[DanielRuf]

https://github.com/webpack/webpack-cli/blob/master/.travis.yml#L42

Travis Ci is very flexible.

[iamkun]

All right, may be we could give it a try

[iamkun]

Let's give it a try.

[xx45]

🎉 This PR is included in version 1.5.20 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀