Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failing unit tests on Node.js 4 #79

Closed
DanielRuf opened this issue May 3, 2018 · 4 comments
Closed

failing unit tests on Node.js 4 #79

DanielRuf opened this issue May 3, 2018 · 4 comments

Comments

@DanielRuf
Copy link
Contributor

I'll probably investigate this but these should not fail. Not yet sure if this is due to the (dev)dependencies or other changes.
@evenstensberg
Copy link
Member

Node 4 is EOL and should probably be dropped

@alexander-akait
Copy link
Member

looks like randomly fail

@DanielRuf
Copy link
Contributor Author

Node 4 is EOL and should probably be dropped

I agree. And 10 should be added.

@alexander-akait
Copy link
Member

@DanielRuf Feel free to send PR 👍

This was referenced May 3, 2018
Merged
Closed
@sokra sokra closed this as completed in #80 Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DanielRuf @alexander-akait @evenstensberg