-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MessageEvent: origin and IDNA #5941
Conversation
Firefox (nightly)Testing web-platform-tests at revision 9d30816 All results1 test ran/webmessaging/event.origin.sub.htm
|
Sauce (safari)Testing web-platform-tests at revision 9d30816 All results1 test ran/webmessaging/event.origin.sub.htm
|
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 9d30816 All results1 test ran/webmessaging/event.origin.sub.htm
|
Chrome (unstable)Testing web-platform-tests at revision 9d30816 All results1 test ran/webmessaging/event.origin.sub.htm
|
And rename “ASCII serialization of an origin” to “serialization of an origin” though allow both to be used. Not all implementations implemented the Unicode variant and the ones that did, did so in a way that made it hard to use. Tests: * web-platform-tests/wpt#5939 * web-platform-tests/wpt#5940 * web-platform-tests/wpt#5941 * web-platform-tests/wpt#5944 * web-platform-tests/wpt#5946 * web-platform-tests/wpt#5955 * web-platform-tests/wpt#5957 * web-platform-tests/wpt#5958 URL Standard change: whatwg/url#311. Service Worker specification follow-up issue: w3c/ServiceWorker#1142. Fixes #2568.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % split nit
@@ -9,7 +9,7 @@ | |||
<div id=log></div> | |||
|
|||
<div style="display:none"> | |||
<iframe width="70%" onload="PostMessageTest()" src="{{location[scheme]}}://{{domains[www]}}:{{location[port]}}/webmessaging/support/ChildWindowPostMessage.htm"></iframe> | |||
<iframe width="70%" onload="PostMessageTest()" src="{{location[scheme]}}://{{domains[天気の良い日]}}:{{location[port]}}/webmessaging/support/ChildWindowPostMessage.htm"></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since at least Firefox was failing this, but perhaps passed the original test, can you keep the existing test and add add a new one?
(If we get to the point where regressions in wpt are taken more seriously, breaking existing tests will be less popular than adding new failing tests.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox passes both variants here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I guess #5941 (comment) is out of date, Firefox changed since then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Firefox fixed its bug already.
And rename “ASCII serialization of an origin” to “serialization of an origin” though allow both to be used. Not all implementations implemented the Unicode variant and the ones that did, did so in a way that made it hard to use. Tests: * web-platform-tests/wpt#5939 * web-platform-tests/wpt#5940 * web-platform-tests/wpt#5941 * web-platform-tests/wpt#5944 * web-platform-tests/wpt#5946 * web-platform-tests/wpt#5955 * web-platform-tests/wpt#5957 * web-platform-tests/wpt#5958 URL Standard change: whatwg/url#311. Service Worker specification follow-up issue: w3c/ServiceWorker#1142. Fixes whatwg#2568.
For whatwg/html#2568.