Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageEvent: origin and IDNA #5941

Merged
merged 1 commit into from
Nov 24, 2017
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented May 16, 2017

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 9d30816
Using browser at version BuildID 20170516100213; SourceStamp 3e166b6838931b3933ca274331f9e0e115af5cc0
Starting 10 test iterations
All results were stable

All results

1 test ran
/webmessaging/event.origin.sub.htm
Subtest Results Messages
OK
Test Description: event.origin returns the origin of the message. FAIL assert_array_equals: ActualResult property 1, expected "http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000" but got "http://天�����.web-platform.test:8000"

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 9d30816
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran
/webmessaging/event.origin.sub.htm
Subtest Results Messages
TIMEOUT
Test Description: event.origin returns the origin of the message. TIMEOUT Test timed out

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 9d30816
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

1 test ran
/webmessaging/event.origin.sub.htm
Subtest Results Messages
TIMEOUT

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 9d30816
Using browser at version 60.0.3095.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/webmessaging/event.origin.sub.htm
Subtest Results Messages
OK
Test Description: event.origin returns the origin of the message. PASS

annevk added a commit to whatwg/html that referenced this pull request May 18, 2017
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes #2568.
@annevk annevk requested a review from foolip November 24, 2017 13:33
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % split nit

@@ -9,7 +9,7 @@
<div id=log></div>

<div style="display:none">
<iframe width="70%" onload="PostMessageTest()" src="{{location[scheme]}}://{{domains[www]}}:{{location[port]}}/webmessaging/support/ChildWindowPostMessage.htm"></iframe>
<iframe width="70%" onload="PostMessageTest()" src="{{location[scheme]}}://{{domains[天気の良い日]}}:{{location[port]}}/webmessaging/support/ChildWindowPostMessage.htm"></iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since at least Firefox was failing this, but perhaps passed the original test, can you keep the existing test and add add a new one?

(If we get to the point where regressions in wpt are taken more seriously, breaking existing tests will be less popular than adding new failing tests.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox passes both variants here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess #5941 (comment) is out of date, Firefox changed since then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Firefox fixed its bug already.

@annevk annevk merged commit 4a878d9 into master Nov 24, 2017
@annevk annevk deleted the annevk/MessageEvent-origin-idna branch November 24, 2017 14:48
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes whatwg#2568.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants