Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageEvent: origin and IDNA #5941

Merged
merged 1 commit into from
Nov 24, 2017
+2 −2
Merged

MessageEvent: origin and IDNA #5941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webmessaging/event.origin.sub.htm
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
<div id=log></div>

<div style="display:none">
<iframe width="70%" onload="PostMessageTest()" src="{{location[scheme]}}://{{domains[www]}}:{{location[port]}}/webmessaging/support/ChildWindowPostMessage.htm"></iframe>
<iframe width="70%" onload="PostMessageTest()" src="{{location[scheme]}}://{{domains[天気の良い日]}}:{{location[port]}}/webmessaging/support/ChildWindowPostMessage.htm"></iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since at least Firefox was failing this, but perhaps passed the original test, can you keep the existing test and add add a new one?

(If we get to the point where regressions in wpt are taken more seriously, breaking existing tests will be less popular than adding new failing tests.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox passes both variants here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess #5941 (comment) is out of date, Firefox changed since then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Firefox fixed its bug already.

<iframe width="70%" onload="PostMessageTest()" src="./support/ChildWindowPostMessage.htm"></iframe>
</div>

@@ -23,7 +23,7 @@
var PORT = location.port !== "" ? ":" + location.port : "";
var TARGET1 = document.querySelectorAll("iframe")[0];
var TARGET2 = document.querySelectorAll("iframe")[1];
var XORIGIN = "{{location[scheme]}}://{{domains[www]}}" + PORT;
var XORIGIN = "{{location[scheme]}}://{{domains[天気の良い日]}}" + PORT;
var SORIGIN = "{{location[scheme]}}://{{host}}" + PORT;
var ExpectedResult = ["#1", XORIGIN, "#2", SORIGIN];
var ActualResult = [];