Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkerLocation: ensure IDNA origin is in ASCII #5940

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented May 16, 2017

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 58f6b6e
Using browser at version BuildID 20170516100213; SourceStamp 3e166b6838931b3933ca274331f9e0e115af5cc0
Starting 10 test iterations
All results were stable

All results

15 tests ran
/workers/WorkerLocation-origin.sub.window.html
Subtest Results Messages
OK
workerLocation.origin must use ASCII code points FAIL assert_equals: expected "http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000" but got "http://天�����.web-platform.test:8000"
/workers/WorkerLocation.htm
Subtest Results Messages
OK
WorkerLocation object PASS
/workers/WorkerLocation_hash.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hash PASS
/workers/WorkerLocation_hash_encoding.htm
Subtest Results Messages
OK
WorkerLocation.hash with url encoding string PASS
/workers/WorkerLocation_hash_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.hash with no <fragment> component PASS
/workers/WorkerLocation_host.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: host PASS
/workers/WorkerLocation_hostname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hostname PASS
/workers/WorkerLocation_href.htm
Subtest Results Messages
OK
WorkerLocation href attribute PASS
/workers/WorkerLocation_pathname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: pathname PASS
/workers/WorkerLocation_port.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: port PASS
/workers/WorkerLocation_protocol.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: protocol PASS
/workers/WorkerLocation_search.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: search PASS
/workers/WorkerLocation_search_empty.htm
Subtest Results Messages
OK
WorkerLocation.search with empty <query> PASS
/workers/WorkerLocation_search_fragment.htm
Subtest Results Messages
OK
WorkerLocation.search with <fragment> in <query> PASS
/workers/WorkerLocation_search_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.search with no <query> component PASS

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 58f6b6e
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

15 tests ran
/workers/WorkerLocation-origin.sub.window.html
Subtest Results Messages
TIMEOUT
workerLocation.origin must use ASCII code points TIMEOUT Test timed out
/workers/WorkerLocation.htm
Subtest Results Messages
OK
WorkerLocation object PASS
/workers/WorkerLocation_hash.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hash PASS
/workers/WorkerLocation_hash_encoding.htm
Subtest Results Messages
OK
WorkerLocation.hash with url encoding string PASS
/workers/WorkerLocation_hash_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.hash with no <fragment> component PASS
/workers/WorkerLocation_host.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: host PASS
/workers/WorkerLocation_hostname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hostname PASS
/workers/WorkerLocation_href.htm
Subtest Results Messages
OK
WorkerLocation href attribute PASS
/workers/WorkerLocation_pathname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: pathname PASS
/workers/WorkerLocation_port.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: port PASS
/workers/WorkerLocation_protocol.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: protocol PASS
/workers/WorkerLocation_search.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: search PASS
/workers/WorkerLocation_search_empty.htm
Subtest Results Messages
OK
WorkerLocation.search with empty <query> PASS
/workers/WorkerLocation_search_fragment.htm
Subtest Results Messages
OK
WorkerLocation.search with <fragment> in <query> PASS
/workers/WorkerLocation_search_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.search with no <query> component PASS

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 58f6b6e
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

15 tests ran
/workers/WorkerLocation-origin.sub.window.html
Subtest Results Messages
TIMEOUT
/workers/WorkerLocation.htm
Subtest Results Messages
OK
WorkerLocation object PASS
/workers/WorkerLocation_hash.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hash PASS
/workers/WorkerLocation_hash_encoding.htm
Subtest Results Messages
OK
WorkerLocation.hash with url encoding string PASS
/workers/WorkerLocation_hash_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.hash with no <fragment> component PASS
/workers/WorkerLocation_host.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: host PASS
/workers/WorkerLocation_hostname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hostname PASS
/workers/WorkerLocation_href.htm
Subtest Results Messages
OK
WorkerLocation href attribute PASS
/workers/WorkerLocation_pathname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: pathname PASS
/workers/WorkerLocation_port.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: port FAIL assert_equals: expected (string) "8000" but got (number) 8000
/workers/WorkerLocation_protocol.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: protocol PASS
/workers/WorkerLocation_search.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: search PASS
/workers/WorkerLocation_search_empty.htm
Subtest Results Messages
OK
WorkerLocation.search with empty <query> FAIL assert_equals: expected "" but got "?"
/workers/WorkerLocation_search_fragment.htm
Subtest Results Messages
OK
WorkerLocation.search with <fragment> in <query> PASS
/workers/WorkerLocation_search_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.search with no <query> component PASS

@ghost
Copy link

ghost commented May 16, 2017

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 58f6b6e
Using browser at version 60.0.3095.5 dev
Starting 10 test iterations
All results were stable

All results

15 tests ran
/workers/WorkerLocation-origin.sub.window.html
Subtest Results Messages
OK
workerLocation.origin must use ASCII code points PASS
/workers/WorkerLocation.htm
Subtest Results Messages
OK
WorkerLocation object PASS
/workers/WorkerLocation_hash.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hash PASS
/workers/WorkerLocation_hash_encoding.htm
Subtest Results Messages
OK
WorkerLocation.hash with url encoding string PASS
/workers/WorkerLocation_hash_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.hash with no <fragment> component PASS
/workers/WorkerLocation_host.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: host PASS
/workers/WorkerLocation_hostname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: hostname PASS
/workers/WorkerLocation_href.htm
Subtest Results Messages
OK
WorkerLocation href attribute PASS
/workers/WorkerLocation_pathname.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: pathname PASS
/workers/WorkerLocation_port.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: port PASS
/workers/WorkerLocation_protocol.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: protocol PASS
/workers/WorkerLocation_search.htm
Subtest Results Messages
OK
WorkerLocation URL decomposition IDL attribute: search PASS
/workers/WorkerLocation_search_empty.htm
Subtest Results Messages
OK
WorkerLocation.search with empty <query> PASS
/workers/WorkerLocation_search_fragment.htm
Subtest Results Messages
OK
WorkerLocation.search with <fragment> in <query> PASS
/workers/WorkerLocation_search_nonexist.htm
Subtest Results Messages
OK
WorkerLocation.search with no <query> component PASS

annevk added a commit to whatwg/html that referenced this pull request May 18, 2017
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes #2568.
@zcorpan zcorpan merged commit d6c43f5 into master Jun 21, 2017
@zcorpan zcorpan deleted the annevk/workerlocation-origin-idna branch June 21, 2017 07:34
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes whatwg#2568.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants