HTML: split out navigation tests for URL query-encoding tests #11300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Jun 1, 2018
|
Happy to file bugs |
|
Safari passes. |
jugglinmike
added a commit
to bocoup/wpt
that referenced
this pull request
Feb 6, 2019
The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests#11300
jugglinmike
added a commit
that referenced
this pull request
Feb 6, 2019
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] #11300
jugglinmike
added a commit
to bocoup/wpt
that referenced
this pull request
Feb 6, 2019
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests#11300
domenic
pushed a commit
that referenced
this pull request
Feb 6, 2019
The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] #11300
annevk
pushed a commit
that referenced
this pull request
Feb 8, 2019
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] #11300
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 21, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 21, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 22, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 22, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 27, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 27, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255 UltraBlame original commit: d2ff85c428aa2bddcf4dc71904e311ffa22edaf0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
UltraBlame original commit: 9b419751710b3922d924ca5400071d90a24a1139
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255 UltraBlame original commit: d2ff85c428aa2bddcf4dc71904e311ffa22edaf0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
UltraBlame original commit: 9b419751710b3922d924ca5400071d90a24a1139
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255 UltraBlame original commit: 2384c1c7af5a385461ca25c280aadaed4e46d3ad
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
UltraBlame original commit: 53e0aa99149f34d0facaa1571ff088c36d1714c7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255 UltraBlame original commit: d2ff85c428aa2bddcf4dc71904e311ffa22edaf0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
UltraBlame original commit: 9b419751710b3922d924ca5400071d90a24a1139
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255 UltraBlame original commit: 2384c1c7af5a385461ca25c280aadaed4e46d3ad
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
UltraBlame original commit: 53e0aa99149f34d0facaa1571ff088c36d1714c7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…encoding, a=testonly Automatic update from web-platform-tests [html] Restore utility method for query encoding The `poll_for_stash` function was relocated from `resolve-url.js` in service of a test refactoring [1]. However, the following tests depend on the presence of that function in that file: - html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html - html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html Restore the function to its original location and persist the copy. [1] web-platform-tests/wpt#11300 -- wpt-commits: 9830c5ab1191c788adf006023da46aea07da46f8 wpt-pr: 15255 UltraBlame original commit: 2384c1c7af5a385461ca25c280aadaed4e46d3ad
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ng, a=testonly
Automatic update from web-platform-tests
HTML: restore coverage for query encoding
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests/wpt#11300
--
wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
UltraBlame original commit: 53e0aa99149f34d0facaa1571ff088c36d1714c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11269 and #4934.
The new test still times out because
pingis not supported, but passes in Firefox withsend_pingspref enabled.