/html/infrastructure/urls/resolving-urls/query-encoding/* are disabled in Mozilla and Chromium #4934

zcorpan · 2017-02-21T11:46:26Z

Need to file browser bugs for failing tests.
Probably should split tests into smaller chunks for each file.
running query-encoding/windows-1251.html I get numerous Python errors
Check if there are problems with stability in test results

annevk · 2017-02-28T12:43:56Z

This blocks #552 basically.

annevk · 2018-05-08T11:03:45Z

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1427268 location.search (not other location setters) is different across browsers.

Helps with #4934.

This also changes how we test the ping IDL attribute as the HTML Standard does not require it to be reflected other than as a string. It also adds testing for <area>. Helps with #4934.

Part of #11269 and #4934.

inexorabletash · 2020-02-18T23:23:27Z

WDYT about splitting these up using variant?

<meta name="variant" content="?include=nested-browsing">
<meta name="variant" content="?include=loading">
<meta name="variant" content="?include=submit">
<meta name="variant" content="?include=base-href">
<meta name="variant" content="?include=workers">
<meta name="variant" content="?include=eventsource">
<meta name="variant" content="?include=xmldocument">
<meta name="variant" content="?include=window-open">
<meta name="variant" content="?include=hyperlink-search">
<meta name="variant" content="?include=history">
<meta name="variant" content="?include=svg">
<meta name="variant" content="?include=xhr">
<meta name="variant" content="?include=websocket">
<meta name="variant" content="?include=appcache">
<meta name="variant" content="?include=css">
<meta name="variant" content="?include=xml">
<meta name="variant" content="?include=url">
<meta name="variant" content="?include=scheme">

This would apply to the utf-8, utf-16be, utf-16le, windows-1251 and windows-1252 tests. Perhaps not as elegant as splitting things up into multiple files, but can get this landed pretty quickly via Chrome.

annevk · 2020-02-19T13:15:54Z

I think that's probably fine and better than the status quo.

These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252) and exercise many features (HTML, CSS, SVG, Workers, ...). They're currently all skipped in Chrome (and other browser CI systems), since something in that huge matrix fails or times out for everyone. #4934 suggests splitting these into separate files. As a stopgap, split them out using the WPT "variant" mechanism and provide expected failure files for subsets, which should make fixing the tests and/or browsers more actionable, and let us catch new regressions. Bug: 930297 Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7

These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252) and exercise many features (HTML, CSS, SVG, Workers, ...). They're currently all skipped in Chrome (and other browser CI systems), since something in that huge matrix fails or times out for everyone. #4934 suggests splitting these into separate files. As a stopgap, split them out using the WPT "variant" mechanism and provide expected failure files for subsets, which should make fixing the tests and/or browsers more actionable, and let us catch new regressions. Bug: 930297 Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063808 Commit-Queue: Philip Jägenstedt <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#743019}

These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252) and exercise many features (HTML, CSS, SVG, Workers, ...). They're currently all skipped in Chrome (and other browser CI systems), since something in that huge matrix fails or times out for everyone. web-platform-tests/wpt#4934 suggests splitting these into separate files. As a stopgap, split them out using the WPT "variant" mechanism and provide expected failure files for subsets, which should make fixing the tests and/or browsers more actionable, and let us catch new regressions. Bug: 930297 Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063808 Commit-Queue: Philip Jägenstedt <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#743019}

inexorabletash · 2020-02-24T21:24:02Z

Per wpt.fyi on the PR, looking for consistent failures across Chrome/Firefox/Safari and encodings:

appcache - TIMEOUTs 2/3 (CACHE and FALLBACK, NETWORK is ok)
history - fails 2/2
xmldocument - fails 1/1 (XMLDocument#load is gone, should just remove these)

And FWIW, only these pass everywhere (all browsers/all encodings)

submit
url
websocket

…testonly Automatic update from web-platform-tests Split html/.../query-encoding/ tests (#21881) These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252) and exercise many features (HTML, CSS, SVG, Workers, ...). They're currently all skipped in Chrome (and other browser CI systems), since something in that huge matrix fails or times out for everyone. web-platform-tests/wpt#4934 suggests splitting these into separate files. As a stopgap, split them out using the WPT "variant" mechanism and provide expected failure files for subsets, which should make fixing the tests and/or browsers more actionable, and let us catch new regressions. Bug: 930297 Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063808 Commit-Queue: Philip Jägenstedt <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#743019} Co-authored-by: Joshua Bell <[email protected]> -- wpt-commits: d40812425800cccad65582ad1132d97303f1f1b9 wpt-pr: 21881

…testonly Automatic update from web-platform-tests Split html/.../query-encoding/ tests (#21881) These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252) and exercise many features (HTML, CSS, SVG, Workers, ...). They're currently all skipped in Chrome (and other browser CI systems), since something in that huge matrix fails or times out for everyone. web-platform-tests/wpt#4934 suggests splitting these into separate files. As a stopgap, split them out using the WPT "variant" mechanism and provide expected failure files for subsets, which should make fixing the tests and/or browsers more actionable, and let us catch new regressions. Bug: 930297 Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063808 Commit-Queue: Philip Jägenstedt <foolipchromium.org> Reviewed-by: Philip Jägenstedt <foolipchromium.org> Cr-Commit-Position: refs/heads/master{#743019} Co-authored-by: Joshua Bell <inexorabletashgmail.com> -- wpt-commits: d40812425800cccad65582ad1132d97303f1f1b9 wpt-pr: 21881 UltraBlame original commit: cc3538c8a2d458466b5528342be6f3249f183259

…tml/.../query-encoding/, a=testonly Automatic update from web-platform-tests WPT: Remove XMLDocument#load test from html/.../query-encoding/ (#21973) Test was failing in all browsers and all encoding permutations. The load() method has been removed from XMLDocument and all browsers. It has coverage in dom/historical.html so isn't needed here. Discussion: https: //github.com/web-platform-tests/wpt/issues/4934#issuecomment-590807673 Change-Id: Ib38a8b6374e26cb69055c61ed4725ecd9b05a267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071251 Auto-Submit: Joshua Bell <[email protected]> Commit-Queue: Stephen McGruer <[email protected]> Reviewed-by: Stephen McGruer <[email protected]> Cr-Commit-Position: refs/heads/master@{#744527} Co-authored-by: Joshua Bell <[email protected]> -- wpt-commits: 3e5f970dc575b9e0131f5e05ac2a70779a5ba386 wpt-pr: 21973

…tml/.../query-encoding/, a=testonly Automatic update from web-platform-tests WPT: Remove XMLDocument#load test from html/.../query-encoding/ (#21973) Test was failing in all browsers and all encoding permutations. The load() method has been removed from XMLDocument and all browsers. It has coverage in dom/historical.html so isn't needed here. Discussion: https: //github.com/web-platform-tests/wpt/issues/4934#issuecomment-590807673 Change-Id: Ib38a8b6374e26cb69055c61ed4725ecd9b05a267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071251 Auto-Submit: Joshua Bell <jsbellchromium.org> Commit-Queue: Stephen McGruer <smcgruerchromium.org> Reviewed-by: Stephen McGruer <smcgruerchromium.org> Cr-Commit-Position: refs/heads/master{#744527} Co-authored-by: Joshua Bell <inexorabletashgmail.com> -- wpt-commits: 3e5f970dc575b9e0131f5e05ac2a70779a5ba386 wpt-pr: 21973 UltraBlame original commit: a147c64bcec260fe194fff43b7d5d710cc90711c

annevk · 2023-01-16T16:12:25Z

I thought this was fixed due to the splitting, but #14519 suggests this was still a problem after the fix got merged.

inexorabletash · 2023-01-17T17:47:05Z

FYI, from https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations?q=TestExpectations&ss=chromium

crbug.com/930297 external/wpt/html/infrastructure/urls/resolving-urls/query-encoding/utf-16be.html?include=workers [ Skip Timeout ]
crbug.com/930297 external/wpt/html/infrastructure/urls/resolving-urls/query-encoding/utf-16le.html?include=workers [ Skip Timeout ]
...

# navigation tests fail or time out when run with run_web_tests.py but passes with run_wpt_tests.py
...
crbug.com/1317067 external/wpt/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=windows-1252 [ Failure Timeout ]
crbug.com/1317067 external/wpt/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251 [ Failure Timeout ]
crbug.com/1317067 external/wpt/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8 [ Failure Timeout ]

I haven't dug in at all, though.

zcorpan · 2023-01-18T14:30:59Z

Checking the results on wpt.fyi for a few shas shows TIMEOUT and ERROR for a few tests across browsers (for different tests), and at least windows-1251.html?include=workers and utf-16be.html?include=workers are flaky in Firefox.

Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1034063

annevk · 2023-09-02T17:49:25Z

Coverage to add:

Various Fetch APIs: Fetch: ensure UTF-8 is used for the URL parser #41894

Issues found:

Assumes nested workers are still a thing: HTML: correct worker URL encoding tests #41783.
Assumes gopher is a special scheme: HTML: "gopher" is no longer a special scheme #41781.
windows-1251 expectations for loading tests are wrong: HTML: correct URL encoding loading tests for windows-1251 #41784.
search setter uses UTF-8: HTML: search setter always uses UTF-8 #41785.
Assumes pushState() uses the current realm rather than the relevant realm: HTML: pushState() url resolves against relevant settings object #41797

Possible specification changes:

SharedWorker is only exposed on Window, not in any worker global. The SharedWorker importScripts() took me a while to debug, but ultimately the problem was that the variable was declared in a function scope and importScripts would attempt to override it in the global scope. As such, the fix is declaring the variable a little earlier on, matching how it's done for Worker importScripts(). Helps with #4934.

It some point windows-1251 was added with an expected query of %26%23229%3B, but the loading tests were never changed to account for that query expectation. This makes them share the windows-1252 expectation which I suppose is not ideal, but unless there's a quick fix I'd prefer that to be follow-up material. Helps with #4934.

SharedWorker is only exposed on Window, not in any worker global. The SharedWorker importScripts() took me a while to debug, but ultimately the problem was that the variable was declared in a function scope and importScripts would attempt to override it in the global scope. As such, the fix is declaring the variable a little earlier on, matching how it's done for Worker importScripts(). Helps with #4934.

It some point windows-1251 was added with an expected query of %26%23229%3B, but the loading tests were never changed to account for that query expectation. This makes them share the windows-1252 expectation which is not ideal and improving that is tracked in #41794. Helps with #4934.

See #4934 (comment)

…elevant settings object, a=testonly Automatic update from web-platform-tests HTML: pushState() url resolves against relevant settings object See web-platform-tests/wpt#4934 (comment) -- wpt-commits: 83a0e8b67f6bb1daf4336060337eee609768a931 wpt-pr: 41797

SharedWorker is only exposed on Window, not in any worker global. The SharedWorker importScripts() took me a while to debug, but ultimately the problem was that the variable was declared in a function scope and importScripts would attempt to override it in the global scope. As such, the fix is declaring the variable a little earlier on, matching how it's done for Worker importScripts(). Helps with web-platform-tests#4934.

It some point windows-1251 was added with an expected query of %26%23229%3B, but the loading tests were never changed to account for that query expectation. This makes them share the windows-1252 expectation which is not ideal and improving that is tracked in web-platform-tests#41794. Helps with web-platform-tests#4934.

See web-platform-tests#4934 (comment)

zcorpan added html url labels Feb 21, 2017

annevk added a commit that referenced this issue May 8, 2018

Extra Location object tests from query-encoding/

13bae16

Helps with #4934.

annevk mentioned this issue May 8, 2018

Extract Location object tests from query-encoding/ #10891

Merged

zcorpan changed the title ~~Clean up html/infrastructure/urls/resolving-urls/query-encoding/~~ /html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html is disabled in Mozilla and Chromium May 8, 2018

annevk added a commit that referenced this issue May 9, 2018

Extract Location object tests from query-encoding/

42006d1

Helps with #4934.

annevk mentioned this issue May 9, 2018

URL/Encoding: change query state parsing #10915

Merged

zcorpan changed the title ~~/html/infrastructure/urls/resolving-urls/query-encoding/utf-8.html is disabled in Mozilla and Chromium~~ /html/infrastructure/urls/resolving-urls/query-encoding/* are disabled in Mozilla and Chromium May 17, 2018

zcorpan added the flaky label May 17, 2018

zcorpan self-assigned this May 17, 2018

annevk added a commit that referenced this issue May 23, 2018

Test query encoding of attributes separately

176ecfb

Helps with #4934.

annevk mentioned this issue May 23, 2018

Test query encoding of attributes separately #11129

Merged

zcorpan added the good first issue label May 25, 2018

zcorpan removed their assignment May 28, 2018

zcorpan added a commit that referenced this issue Jun 1, 2018

HTML: split out navigation tests for URL query-encoding tests

26be20c

Part of #11269 and #4934.

zcorpan mentioned this issue Jun 1, 2018

HTML: split out navigation tests for URL query-encoding tests #11300

Merged

zcorpan added a commit that referenced this issue Jun 1, 2018

HTML: split out navigation tests for URL query-encoding tests

596c572

Part of #11269 and #4934.

zcorpan mentioned this issue Jun 4, 2018

Test sendBeacon in url query encoding testsuite #552

Open

hyspace mentioned this issue Jun 11, 2019

Improve WHATWG Url Spec Conformance AngleSharp/AngleSharp#802

Open

chromium-wpt-export-bot mentioned this issue Feb 19, 2020

Split html/.../query-encoding/ tests #21881

Merged

zcorpan mentioned this issue Aug 28, 2020

Remove some useless test-level properties #14519

Merged

annevk mentioned this issue Sep 3, 2023

HTML: correct worker URL encoding tests #41783

Merged

annevk mentioned this issue Sep 3, 2023

HTML: correct URL encoding loading tests for windows-1251 #41784

Merged

annevk removed the good first issue label Sep 4, 2023

zcorpan added a commit that referenced this issue Sep 4, 2023

HTML: pushState() url resolves against relevant settings object

70737aa

See #4934 (comment)

zcorpan mentioned this issue Sep 4, 2023

HTML: pushState() url resolves against relevant settings object #41797

Merged

zcorpan added a commit that referenced this issue Sep 4, 2023

HTML: pushState() url resolves against relevant settings object

83a0e8b

See #4934 (comment)

annevk mentioned this issue Sep 8, 2023

navigate() should not use parse a URL whatwg/html#9708

Closed

Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023

HTML: pushState() url resolves against relevant settings object

4a5b699

See web-platform-tests#4934 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

/html/infrastructure/urls/resolving-urls/query-encoding/* are disabled in Mozilla and Chromium #4934

/html/infrastructure/urls/resolving-urls/query-encoding/* are disabled in Mozilla and Chromium #4934

zcorpan commented Feb 21, 2017

annevk commented Feb 28, 2017

annevk commented May 8, 2018 •

edited

Loading

inexorabletash commented Feb 18, 2020

annevk commented Feb 19, 2020

inexorabletash commented Feb 24, 2020

annevk commented Jan 16, 2023

inexorabletash commented Jan 17, 2023

zcorpan commented Jan 18, 2023

annevk commented Sep 2, 2023 •

edited

Loading

/html/infrastructure/urls/resolving-urls/query-encoding/* are disabled in Mozilla and Chromium #4934

/html/infrastructure/urls/resolving-urls/query-encoding/* are disabled in Mozilla and Chromium #4934

Comments

zcorpan commented Feb 21, 2017

annevk commented Feb 28, 2017

annevk commented May 8, 2018 • edited Loading

inexorabletash commented Feb 18, 2020

annevk commented Feb 19, 2020

inexorabletash commented Feb 24, 2020

annevk commented Jan 16, 2023

inexorabletash commented Jan 17, 2023

zcorpan commented Jan 18, 2023

annevk commented Sep 2, 2023 • edited Loading

annevk commented May 8, 2018 •

edited

Loading

annevk commented Sep 2, 2023 •

edited

Loading