[html] Restore coverage for query encoding #15256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:
$ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
Explicitly declare the default variant, restoring the original test
coverage.
[1] web-platform-tests#11300
zcorpan
approved these changes
Feb 6, 2019
|
Could you also update the other .sub.html files in that directory? Thanks for catching this! |
Although the `windows-1252` character set will be used when a variant is not specified, the automation tooling only uses variants which are explicitly specified. Explicitly declare the default variant in order to extend test coverage.
|
You got it, @annevk |
annevk
approved these changes
Feb 8, 2019
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
--list-testsflag of thewpt runcommand:Explicitly declare the default variant, restoring the original test
coverage.
[1] #11300