-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreviewed scope increase in URL since Interop 2023 launch #338
Comments
cc @annevk |
Thanks @foolip. To be clear, I didn't mean to increase the scope of Interop 2023. And I'd much rather have other browsers focus on their URL parser than these API extensions. |
No problem, there's nothing preventing changing the tests that are labeled for Interop 2023, so things like this are bound to happen. Unfortunately we have no mechanism for targeting or filtering out subtests, so I don't know how we'd go about this. We could just hack something into the scoring script, and try to generalize if we have more cases like this. |
@jgraham can you review this from the Gecko side? |
I think we're reluctant to add additional scope to the URL focus area. New API features seem like they should be considered for Interop 2024 rather than added to the existing tests. |
I found one additional change to the idlharness tests that came via web-platform-tests/wpt#38345, the |
To make the suggestion concrete:
In parallel I'll check if a fix for the "%EF%BF%BF=%EF%BF%BF" test would be trivial, in which case we can perhaps just fix it. No promises though. |
Sounds good. I think it would be okay to exclude the |
That would make sense, and leaves urlencoded-parser.any.js covering the parsing behavior. |
I've created web-platform-tests/wpt-metadata#4244 to show what the test list change would be. @annevk do you need anything more to make a call on this? I haven't updated up the scoring script yet, waiting to hear back about the feasibility of fixing the "%EF%BF%BF=%EF%BF%BF" cases. |
For WebKit that seems fine. I'll flag it internally just in case, but I don't foresee any issue. |
cc @valenting |
I'm OK with dropping them, but I don't feel strongly about it. |
Good news regarding the "" tests. @hayatoito has a fix for this in progress in https://chromium-review.googlesource.com/c/chromium/src/+/4567772 so we're OK keeping that in scope. That means web-platform-tests/wpt-metadata#4244 is the complete change being proposed. We have support from Gecko (@valenting) and WebKit (@annevk) on this issue, so I'll land the PR and close this issue. |
Test List
https://wpt.fyi/results/url/idlharness.any.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop
https://wpt.fyi/results/url/idlharness.any.worker.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop
https://wpt.fyi/results/url/urlencoded-parser.any.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop
https://wpt.fyi/results/url/urlencoded-parser.any.worker.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop
https://wpt.fyi/results/url/urlsearchparams-delete.any.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop
https://wpt.fyi/results/url/urlsearchparams-delete.any.worker.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop
https://wpt.fyi/results/url/urlsearchparams-has.any.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop
https://wpt.fyi/results/url/urlsearchparams-has.any.worker.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop
Rationale
There are new failing subtests in these tests due to changes post-launch.
web-platform-tests/wpt#38953 was written for https://bugs.chromium.org/p/chromium/issues/detail?id=633153, but wasn't part of the scope originally.
web-platform-tests/wpt#39865 is for whatwg/url#735, which is a new feature. (It might be trivial to implement, I don't know.)
If we don't have support from everyone to include these, we should exclude these subtests from Interop 2023.
The text was updated successfully, but these errors were encountered: