Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync interfaces/ with @webref/idl 3.33.0 #38345

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Sync interfaces/ with @webref/idl 3.33.0 #38345

merged 1 commit into from
Apr 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 3, 2023

This automated pull request updates interfaces/*.idl from @webref/idl 3.33.0.

Before merging, please check that any tests that depend on the updated IDL files still work. In particular, check for gray boxes as the wpt.fyi check status, which usually means that some tests have regressed.

If additional changes are needed, please manually create another PR based on this one.

See the workflow for how this pull request was created, and the README for how the IDL files in this directory are used.

@wpt-pr-bot wpt-pr-bot requested a review from foolip February 3, 2023 12:09
@github-actions github-actions bot force-pushed the actions/update-idl branch 4 times, most recently from 4be627f to b258666 Compare February 8, 2023 12:10
@github-actions github-actions bot changed the title Sync interfaces/ with @webref/idl 3.25.0 Sync interfaces/ with @webref/idl 3.25.1 Feb 9, 2023
@github-actions github-actions bot force-pushed the actions/update-idl branch 5 times, most recently from 3214f71 to d2c102a Compare February 13, 2023 12:10
@foolip
Copy link
Member

foolip commented Feb 13, 2023

This will require getting rid of the tentative test for popover. @josepharhar @mfreed7 can either of you take a look at doing that in a separate PR that takes the changes to html.idl from this PR and makes the additional changes required to test popover as part of the big HTML idlharness test?

@mfreed7
Copy link
Contributor

mfreed7 commented Feb 13, 2023

This will require getting rid of the tentative test for popover. @josepharhar @mfreed7 can either of you take a look at doing that in a separate PR that takes the changes to html.idl from this PR and makes the additional changes required to test popover as part of the big HTML idlharness test?

So I put up a CL to do the .tentative.html -> .html rename. As for the idlharness test, what's required? Note that there's already an idlharness test specific to popover:

https://wpt.fyi/results/html/semantics/popovers/idlharness.tentative.html?label=master&label=experimental&aligned&view=subtest&q=popovers

Perhaps that should just get merged somewhere?

@foolip
Copy link
Member

foolip commented Feb 13, 2023

@mfreed7 this PR brings in the IDL for popover from the HTML spec, so I'm guessing the dedicated test isn't needed any longer?

It is a bit unfortunate that it all ends up in one big test of course, but I don't know how to improve on that unless IDL is grouped by feature in specs or something like that.

@github-actions github-actions bot force-pushed the actions/update-idl branch 6 times, most recently from 8a3beb2 to 83af7a6 Compare February 19, 2023 12:09
@github-actions github-actions bot changed the title Sync interfaces/ with @webref/idl 3.25.1 Sync interfaces/ with @webref/idl 3.26.0 Feb 20, 2023
@github-actions github-actions bot force-pushed the actions/update-idl branch 3 times, most recently from f2bc03a to ac07b1a Compare February 22, 2023 12:11
@github-actions github-actions bot changed the title Sync interfaces/ with @webref/idl 3.26.0 Sync interfaces/ with @webref/idl 3.27.0 Feb 23, 2023
@github-actions github-actions bot force-pushed the actions/update-idl branch 3 times, most recently from 754f190 to 5b817f6 Compare February 25, 2023 12:09
@miketaylr
Copy link
Member

miketaylr commented Mar 30, 2023

OK, so the web-animations idl regression seems intentional - AnimationTimeline was moved from web-animations.idl to scroll-animations.idl

For Safari, the change in webrtc-stats/supported-stats.html looks related to 61989c5, so that might have revealed a bug?

@foolip
Copy link
Member

foolip commented Mar 30, 2023

The change in webrtc-stats/supported-stats.https.html seems weird. The only change to the IDL shouldn't have affected any tests. Maybe that test is already flaky?

@miketaylr
Copy link
Member

The only change to the IDL shouldn't have affected any tests. Maybe that test is already flaky?

Yeah, I confirmed locally that checking out the idl before that change doesn't affect test results. I re-ran the test about 25 times here, but wasn't able to repro a flake, but it's the most likely solution.

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can land this as-is, but let's let CI finish running.

@miketaylr
Copy link
Member

@jgraham is it normal for wpt-firefox-nightly-stability to take more than 8 hours?

Screenshot 2023-03-30 at 4 34 23 PM

@github-actions github-actions bot force-pushed the actions/update-idl branch from 4c9b277 to daa9200 Compare March 31, 2023 12:10
@miketaylr
Copy link
Member

All the Firefox failures relate to webtransport, which isn't supported in Firefox (according to MDN), so let's go ahead and land this.

@miketaylr
Copy link
Member

(but probably need @foolip or @jgraham to force merge it!)

@github-actions github-actions bot force-pushed the actions/update-idl branch 5 times, most recently from a57684b to f5be4ba Compare April 5, 2023 12:10
@github-actions github-actions bot changed the title Sync interfaces/ with @webref/idl 3.31.0 Sync interfaces/ with @webref/idl 3.32.0 Apr 6, 2023
@github-actions github-actions bot force-pushed the actions/update-idl branch 6 times, most recently from b05f681 to c7f7780 Compare April 12, 2023 12:09
@github-actions github-actions bot changed the title Sync interfaces/ with @webref/idl 3.32.0 Sync interfaces/ with @webref/idl 3.33.0 Apr 13, 2023
@github-actions github-actions bot force-pushed the actions/update-idl branch from c7f7780 to b29c30e Compare April 13, 2023 12:09
@jgraham jgraham merged commit 1013efd into master Apr 14, 2023
@jgraham jgraham deleted the actions/update-idl branch April 14, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants