-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unintended scope changes to active focus areas #346
Comments
@zcorpan any thoughts on how to implement this? The labels are in https://github.com/web-platform-tests/wpt-metadata and can be accessed via a wpt.fyi API. Either would be an external dependency which would increase the risk of CI failures if those dependencies are not reliable. |
I had in mind doing a git clone of the wpt-metadata repo. I'm not so familiar with the wpt.fyi API. No opinion on which approach to use. If there are network issues we could have a retry (or several retries with increased timeout). |
Looks like the API is undocumented (web-platform-tests/wpt.fyi#3337) but one can get all of the labels in a single API call at https://wpt.fyi/api/metadata?product=chrome&includeTestLevel. Whether using that API or a clone of the wpt-metadata repo, we'd get a list of test names. I'm a bit unsure how to implement the rest of the check, but it is possible of course. |
I think there's code to determine "affected tests" for a PR for running stability checks, which maybe we could reuse? cc @jgraham |
We discussed this in #660. Concrete next steps here could be a GitHub Actions workflow that does:
|
Maybe we should have a CI check (in wpt) to avoid test changes for tests in interop-* (for active focus areas). Require a commit message to link to an issue in the interop repo?
c.f. #345 , #338
The text was updated successfully, but these errors were encountered: