feat(Rln relay): Improves rln-chat2 interface, displays links to the registration tx, warns about spam messages

[staheri14]

Thie PR is a progress towards #1069
Addresses a subset pf comments re "chat interface", namely:

• Warns users when about their spamming activity
• Provides users with a link to their registration tx on Goerli testnet

[LNSD]

I understand that at this moment the goal is to have a prototype where the user is using the command-line. So the comments below are just suggestions 😁

IMO, writing to the stdout (via echo, or via any other means) should only happen from the main application, the nodewaku2 in our case.

Can we make the "warning" an event that can be consumed in the future by other APIs (e.g., an android/ios app that wraps the nwaku implementation). In that case, you cannot use the stdout to notify the user.

So in this case I would create a callback to the "warning event" and hook it in nodewaku2 and call echo inside the callback method.

[jm-clius]

LGTM. Feel free to mark as ready for review when it is. Agree with @LNSD that the chat2 toy application can do with a cleanup, though this is an effort separate from RLN.

[staheri14]

IMO, writing to the stdout (via echo, or via any other means) should only happen from the main application, the nodewaku2 in our case.

Can we make the "warning" an event that can be consumed in the future by other APIs (e.g., an android/ios app that wraps the nwaku implementation). In that case, you cannot use the stdout to notify the user.

So in this case I would create a callback to the "warning event" and hook it in nodewaku2 and call echo inside the callback method.

@LNSD I believe that the current implementation is also event-driven. The mountRlnRelay proc accepts a callback function to be triggered when the registration tx gets mined. The callback function is defined and passed by the chat2 user (the main program) and contains the print statement. Do you suggest something different than this?

[staheri14]

@jm-clius Thanks, forgot to mark it as ready when added the reviewers. It is now marked as ready!

[staheri14]

@LNSD I see, I think your suggestion is about the publish proc which prints a warning about spamming. I can also update the interface of that proc to accept a callback function. Already on it.

Update: This implies a bit of careful refactoring (as publish proc is nested inside a few other procs),I don't want to rush the implementation, so opened a tracking issue to address it in a follow up PR #1083 Feel free to continue the conversation on this matter on the tracking issue.

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	eae530e	#1	2022-08-20 04:06:44	~19 min	macos	📦bin
❌	eae530e	#2	2022-08-21 22:13:50	~29 min	windows	📄log
❌	eae530e	#3	2022-08-22 22:46:55	~3 min	windows	📄log

[LNSD]

LGTM ✅

[jm-clius]

LGTM!