Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling print statements in chat2 using EDD pattern (specific to waku-rln-relay) #1083

Closed
staheri14 opened this issue Aug 19, 2022 · 1 comment

Comments

@staheri14
Copy link
Contributor

staheri14 commented Aug 19, 2022

Problem

Print statements should ideally happen inside the main program, but not from inside other procedures in an ad-hoc manner.
Right now in chat2, this pattern is violated in the publish proc where a warning message is printed on the console when a published message is found spam.
This issue is to address this anti-pattern. Possibly by updating a few function interfaces to accept a callback function to be invoked at the time that a spam message is about to be published.

@staheri14 staheri14 added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Aug 20, 2022
@staheri14 staheri14 moved this to Next/Backlog in Vac Research Aug 24, 2022
@staheri14 staheri14 moved this from Next/Backlog to Later/Icebox in Vac Research Oct 14, 2022
@rymnc rymnc added track:rlnp2p and removed track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Jan 19, 2023
@jm-clius
Copy link
Contributor

Unlikely to be implemented with the new approach to RLN integration.

@jm-clius jm-clius closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
@github-project-automation github-project-automation bot moved this from Later/Icebox to Done in Vac Research Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants