RLN-Relay testnet feedbacks

[staheri14]

Created this issue to track comments collected from on-chain rln-relay testnet.

Write up edits: (corresponding PR #1068)

• (G) one screenshot has "endpoint" and "secret" in clear, while in the next one are blurred
• (G) there is an extra line after the first registration command
• Hiding the membership index so that users know they need to input their own index
• Spacing inconsistency in the chat2 commands
• Emphasize that the ethereal client address should be a web socket address

Rln credentials (corresponding PR #1080)

• (R) Updating the tutorial to signify that RLN credentials are being persisted in a separate file. Otherwise, all the chat2 instances read and use the same credentials.
• (G) warn users with a message when a local credential file is loaded, specifying that no membership regsitration was executed.
• (G) Allow re-registration even when the rlncredentials.txt file is present. Maybe via an extra parameter --force-registration=true ((S)the cleanest path would be to just rely on one input path, either the file or cli arguments, but not both.)
• (R) Allowing multiple rlnCredentials.txt files for distinct chat2 apps running on the same machine. Potentially prefixing the filenames with the Ethereum account address (good but not sufficient)

Chat interface: (corresponding PR #1082)

• (R) It would be nice to see an indication that a message you are sending is considered spam. The only way to know is by opening two chat2 apps and seeing that one does not receive the messages from the other
• (R) After rln-relay preparation is in progress ..., print a link to etherscan to see the transaction details

Error handling:

• (F) chat2 should handle the error when a http address for the Ethereum client address is passed instead of printing the unhandled exception
• (F) Validate RLN credentials and let the user know if invalid. no longer valid since we removed the manual rln credential config option and replaced it with a file, so the code write and reads the data to/from a file with no user intervention
• (R) Proper error handling when using an account without funds
• (G) Resources are not released when chat2 is terminated by ctrl+c, this should be fixed. seems already supported

Requested features:

• (G) When reusing rln credentials, user should not need to pass the ethereum address/private key. Tracking issue chore (rln-relay): Make the Eth account address and private key optional  #1116

Out of scope

• Pick a store node at random (but not always the first one) tracking issue bug: Store node selection is not random  #1110
• [chat2 specific] the store messages should be displayed in ASC order so the newest messages appear at the bottom. tracking issue bug: order of historical messages in chat2 #1111

Future

• (G) since rlnCredentials.txt values are parsed from json, you can change them in order to overflow conversion and crash node ((S) it dictates the necessity of the input validation) (this will be addressed once using keys-store for persistence of the rln credentials ). Tracking issue feat: Check field size when loading rln credential file #1113
• (R) Encrypting the content of rlnCredentials.txt (will be addressed after integrating key-store). Tracking issue #1114
• (R) Displaying an ascii loading indicator for 1) when connecting to the store nodes 2) when rln-relay preparation is in progress. Tracking issue chore: Adding an ASCII loading indicator when chat2 setup is in progress #1115
• (F) Passing a config file instead of command-line options. Tracking issue feat: Passing a config file instead of command-line options to the chat2 #1112

[staheri14]

Closing the issue as the testnet comments are either addressed or captured in a tracking issue.