Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (rln-relay): Make the Eth account address and private key optional #1116

Closed
staheri14 opened this issue Sep 1, 2022 · 0 comments · Fixed by #1258
Closed

chore (rln-relay): Make the Eth account address and private key optional #1116

staheri14 opened this issue Sep 1, 2022 · 0 comments · Fixed by #1258
Assignees
@rymnc
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@staheri14
Copy link
Contributor

staheri14 commented Sep 1, 2022 •
edited
Loading

Background

In the waku-rln-relay protocol, if a user wishes to reuse its persisted credentials then naturally the user should not need to pass its Ethereum address and private key (as no registration tx is to be sent). However, currently, the waku-rln-relay protocol in on-chain mode requires the Ethereum address and private key regardless.

Acceptance criteria

  • Make the Eth account address and private key optional when no on-chain registrations are to be done. This entails an update to the configs and the mounting procedure.
@staheri14 staheri14 added track:maintenance track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Sep 1, 2022
@staheri14 staheri14 mentioned this issue Sep 1, 2022
Closed
15 tasks
@jm-clius jm-clius removed this from Waku Sep 2, 2022
@staheri14 staheri14 moved this to Later/Icebox in Vac Research Sep 13, 2022
@staheri14 staheri14 moved this from Later/Icebox to Now/In Progress in Vac Research Sep 22, 2022
@staheri14 staheri14 moved this from Now/In Progress to Next/Backlog in Vac Research Sep 22, 2022
@rymnc rymnc self-assigned this Sep 27, 2022
@rymnc rymnc mentioned this issue Oct 11, 2022
Merged
Repository owner moved this from Next/Backlog to Done in Vac Research Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymnc rymnc

Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rln-relay): make account address optional waku-org/nwaku
2 participants
@staheri14 @rymnc