Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up g.part 5 #871

Closed
vincentvanhees opened this issue Aug 7, 2023 · 0 comments · Fixed by #872
Closed

Clean up g.part 5 #871

vincentvanhees opened this issue Aug 7, 2023 · 0 comments · Fixed by #872

Comments

@vincentvanhees
Copy link
Member

vincentvanhees commented Aug 7, 2023

Given that there are various expansions and enhancements to part 5 (#839, #817, #807, #687) in planning, I am exploring how to first clean up g.part 5 to reduce length and complexity of code.

Draft plan for now:

  1. Code to prepare the ts object including essential columns such as diur, ACC. Maybe this part can stay inside g.part5 as it is relevant for all following sub-functionalities.
  2. Code to describe data per segment (MM, WW, or shorter segments). Maybe this could be called g.part5_analyseSegment:
  3. Code to perform circadian rhythm analyses not dependent on window descriptions, but potentially in need of selecting time window between first wakeup/onset and last wakeup/onset. g.part5_analyseMultiday

Here it would be good to already account for:

  • Option to express focus, e.g. focus on part 5 means that all potentially overlapping analysis in part 2 are skipped there.
  • Option to run different parts at different resolutions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant