Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up g.part5() #872

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Clean up g.part5() #872

merged 5 commits into from
Aug 9, 2023

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Aug 7, 2023

Fixes #871
In this PR I am moving large sections of the g.part5 function code to two new functions:

  • One new function for all analyses per segment
  • One new function to initialise data.frame ts

Note:

  • This does not include any work on circadian rhythm yet, it is only preparation work for rest of the year.
  • This does not include any other functional changes. I only copied code, checked that the tests still pass, and documented the new functions.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

@vincentvanhees vincentvanhees changed the title Issue871 cleanup part5 Clean-up g.part5() Aug 7, 2023
@vincentvanhees vincentvanhees changed the title Clean-up g.part5() Clean up g.part5() Aug 7, 2023
@vincentvanhees vincentvanhees merged commit 141c6af into master Aug 9, 2023
@vincentvanhees vincentvanhees deleted the issue871_cleanup_part5 branch August 9, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up g.part 5
1 participant