-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required properties needs updating #30
Comments
2.2.4.2 also only recommends author and readby, but the recommended property list suggests all creators are recommended. (I doubt any publication would ever need every possible kind of creator, so this was a beef I had with wpub's list before we closed that work down.) |
The validation step in the processing algorithm will also need to be updated to issue validation errors when any of the recommended metadata is missing. |
I see these two are still required. If that's the case, it complicates the processing algorithm in pub manifest as we don't define a way to skip the harvesting of values. /cc @iherman |
Although I was thinking last night that if the reading order is empty we could make it a critical failure at the end of the validation stage, which would prevent falling through to harvesting defaults. I don't think there's any way to stop harvesting of the title, but that's not the end of the world since the UA has to generate one anyway during processing. It'll just require a validation error. |
Trying to extend the validation algorithm, I see some problems in the list:
I'd at least suggest taking those items out of the list. |
I agree an empty readingOrder would be a critical failure, since... what's the point of a publication with no content? I'm not sure I want to take resourceList out of recommended, I'm ok to remove privacyPolicy and accessibilityReport, though I do want the latter to be encouraged. These are recommendations afterall, not requirements. |
They may be recommendations, but warnings have a bad history in epub. Issuing a warning because someone doesn't have any resources so they didn't include an unneeded property seems a bit heavy handed. Same with links. But to be clear, it wasn't the relationships I'm worried about as much as resources, links, language and direction. Nothing is wrong with a manifest that omits those properties when they aren't needed. |
Although looking at "base direction", it points to Change the name to "publication language" and the link to https://www.w3.org/TR/pub-manifest/#inLanguage and my concern disappears (for language and direction). |
Closing this as the remaining items are raised in other issues now. I cluttered this one up enough. :) |
I noticed that
@context
andconformsTo
aren't listed as required in https://w3c.github.io/audiobooks/#audio-requirementsIs it the case that title and readingOrder are never harvested from the PEP? If not, they should only be recommended in the authored manifest.
The text was updated successfully, but these errors were encountered: