Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend manifest processing for audio rules #45

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Nov 12, 2019

Here's a start on extending the manifest processing algorithms. It will need to be updated depending on how the various issues I've opened are resolved. (I promise no more now! :)


Preview | Diff

@iherman
Copy link
Member

iherman commented Nov 12, 2019

"Genreating" -> "Generating" (in the manifest processing steps right at the start in the title)

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking, I am fine with the changes. (Although I still have to implement these to see they work well)

However... I am a little bit concerned that we are much stricter for audiobooks than for the general manifest, which looks like setting the bar for an audiobook fairly high (although they are all validation errors). I hope we are fine with that...

@mattgarrish
Copy link
Member Author

I am a little bit concerned that we are much stricter for audiobooks than for the general manifest

Right, that's what I raised a bit of here: #30 (comment)

Those are the most problematic recommended items I see, but even still there's arguably a number of other properties that aren't warning worthy for every audiobook.

@wareid
Copy link
Contributor

wareid commented Nov 12, 2019

I'm ok with audiobooks processing being stricter, mainly because the format has limitations we've defined in the spec and I don't think we're being unnecessarily strict with holding to those in processing. I'll merge so the masses can read too :).

@wareid wareid merged commit b75a560 into master Nov 12, 2019
@mattgarrish mattgarrish deleted the feature/add-processing branch February 6, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants