Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address is canonical identifier? #32

Closed
mattgarrish opened this issue Oct 22, 2019 · 3 comments
Closed

address is canonical identifier? #32

mattgarrish opened this issue Oct 22, 2019 · 3 comments

Comments

@mattgarrish
Copy link
Member

This sentence could probably use some clarifying:

The address of the primary entry page is also the canonical identifier (i.e., it serves as its unique identifier) for the audiobook when present.

Address here points to the address property in pub manifest, but wouldn't this be the actual location of the entry page (address is supposed to be other addresses that get you to the publication/pep).

But what if a canonical identifier is already specified in the manifest, is this sentence saying it has to be overridden when the pep has an address (when doesn't it?), or only added if an identifier isn't present? In either case, this would require extending the processing algorithm to add this info from the html since we don't harvest the url.

I'm not sure exactly how best to reformulate this, but a quick idea might be to say:

When a canonical identifier is not specified in the manifest, user agents MUST use the address of the primary entry page (i.e., the address serves as the unique identifier for the audiobook).

I just wonder about harvesting when the audiobook isn't web hosted (i.e., in a package). You get an absolute url resolved from some potentially inconsistent base.

@mattgarrish
Copy link
Member Author

FYI: w3c/wpub#453

wareid added a commit that referenced this issue Nov 11, 2019
Addressing Matt's comments in
#30
#31
#32
#33
#34
#35
#36
@mattgarrish
Copy link
Member Author

Hm, what I wrote above isn't valid. I should have looked at the definition, but it contradicts the manifest statement that user agents not try to construct canonical identifiers when they aren't present. The address of the PEP could just be a local file:// address, or could change depending on where that gets processed.

I think with this statement we can just drop it entirely.

@mattgarrish
Copy link
Member Author

I don't see this anymore, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant