-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Elastic DSL / bodybuilder from frontend #2167
Comments
I would consider Elasticsearch JS library for that as replacement for bodybuilder. |
We removed elasticsearch-js as a bundle size optimization - it's not a way to go for sure. |
Its all about sending the SearchQuery object in plain json to /api/catalog and then construct elasticsearch query in API instead of constructing it in the client. The SearchAdapter and ElasticsearchQuery classes should be refactored simplified |
@andrzejewsky can you please take care of this one after finishing the tasks from 1.11 please? |
@pkarw yeah, sure 🎉 |
What is the motivation for adding/enhancing this feature?
This is related to #2166
bodybuilder
is about 200KB - and in fact the Elastic query DSL could be constructed 100% in thevue-storefront-api
In that case the catalog.js endpoint no longer will be raw proxy but it will do the logic which is currently done on frontend.
So, the thing is that
vue-storefront-api
should get the simple query object and build DSL itself. It will also makevue-storefront-api
... in fact simpler. Because being partially a proxy to Elastic and partially a REST API isn't easy to understand.What are the acceptance criteria
vue-storefront
dependenciesconfig
option - as some other implementations can base even directly onbodybuilder
we should have an option in both:vue-storefront
andvue-storefront-api
configs to switch this new mode on/off (default is: on)@patzick and @mdanilowicz let me know what do You think on that?
The text was updated successfully, but these errors were encountered: