Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract all search queries to API #2837

Closed
2 of 5 tasks
lukeromanowicz opened this issue Apr 30, 2019 · 5 comments
Closed
2 of 5 tasks

Extract all search queries to API #2837

lukeromanowicz opened this issue Apr 30, 2019 · 5 comments
Labels
5: Complex feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Milestone

Comments

@lukeromanowicz
Copy link
Contributor

lukeromanowicz commented Apr 30, 2019

What is the motivation for adding / enhancing this feature?

  1. will make the client lighter by removing unnecessary code possibly along with some dependencies
  2. will make the environment more secure by restricting access to ElasticSearch
  3. will simplify the vsf code it terms of maintenance and improve platform agnosticism

What are the acceptance criteria

  • search queries are stored in ES instead of hardcoded/generated in vsf
  • new search queries have simplified endpoints in API which allow querying specific information with short and simple http requests.
  • all relevant configurations are moved from vsf to vsf-api

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

It only makes sense to implement it as BC (instead of keeping both ways still available and make things even worse this way).

@lukeromanowicz lukeromanowicz added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can 5: Complex labels Apr 30, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 30, 2019

Related to #2166 and #2167 -> more to this one

@cristian-g
Copy link

Hi! Which branch is being used for the development of this feature request?

@lukeromanowicz
Copy link
Contributor Author

@cristian-g As the Release Cycle section says, it should be based on develop but it looks like nobody is currently working on this one.

@cristian-g
Copy link

Yes @lukeromanowicz but as @pkarw started something related to this some time ago (https://github.com/pkarw/vue-storefront/tree/feature/2166_simple_backend), are contributions expected to be forks from pkarw/vue-storefront or from DivanteLtd/vue-storefront? Maybe contributors can fork pkarw/vue-storefront, commit to 2166_simple_backend and the @pkarw could merge that to DivanteLtd/vue-storefront (just an idea!)

@pkarw

This comment has been minimized.

@pkarw pkarw added this to the 1.11.0-rc.1 milestone Aug 23, 2019
@pkarw pkarw modified the milestones: 1.11.0-rc.1, 2.0-rc Aug 31, 2019
@andrzejewsky andrzejewsky modified the milestones: 1.12.0-rc2, 1.11.0 Oct 14, 2019
@pkarw pkarw modified the milestones: 1.11.0, 1.12.0-rc1 Nov 7, 2019
@pkarw pkarw closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5: Complex feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Projects
None yet
Development

No branches or pull requests

4 participants