-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bodybuilder removed (#2167), bundle size optimizations (#2232) #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
changed the title
[WIP]: Feature/2167
[WIP]: bodybuilder removed (#2167), bundle size optimizations (#2232)
Dec 28, 2019
pkarw
changed the title
[WIP]: bodybuilder removed (#2167), bundle size optimizations (#2232)
bodybuilder removed (#2167), bundle size optimizations (#2232)
Dec 30, 2019
pkarw
added
the
QA - Ready for tests
This is notification for testers, that improvement is ready to be tested and verified.
label
Dec 30, 2019
…ified builder functions with the vs-api
… amp links removed
andrzejewsky
force-pushed
the
feature/2167
branch
from
January 13, 2020 11:09
f179c57
to
28b0d47
Compare
andrzejewsky
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really good work! works fine @pkarw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
QA - Ready for tests
This is notification for testers, that improvement is ready to be tested and verified.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
related PR: vuestorefront/vue-storefront-api#390
related Project: https://github.com/DivanteLtd/storefront-query-builder/
closes #2167 and partially #2232
api-search-query
which is just passing the rawSearchQuery
to the backend - nobodybuilder
importedSearchQuery
andqueryBuilder
to separate repo https://github.com/DivanteLtd/storefront-query-builder which is now shared betweenvue-storefront
andvue-storefront-api
and will be shared withstorefront-api
as wellconfig.api
fromapi-search-query
toapi
. No other changes required.amp-renderer
module (it's disabled in thesrc/modules/index.ts
)google-tag-manager
module (it's disabled in thesrc/modules/index.ts
)Note: If you still need
bodybuilder
it's in the package.json so you can just useimport bodybuilder from 'bodybuilder'
- that's it.Testing instruction
vue-storefront-api
that supportssearch-query
: feature/2167 vue-storefront-api#390config.server.api
toapi-search-query
; recompile API + frontendOverall effect: simplified business logic (no Elastic DSL construction in the frontend); -400kB over
app.js
bundleNext steps:
amp-renderer module disabled
vue-storefront-api
part - currently, it's missing some important config variables so the final query is not properly built,storefront-query-builder
and continue the extension works as requested in Extendable Elasticsearch queries #3934