To do before release #246

eddyerburgh · 2017-12-09T17:10:58Z

lmiller1990 · 2017-12-12T15:39:34Z

I think you have the wrong issue reference for Add docs for testing components that have asynchronous calls ?

I am interested in writing docs for this! This basically refers to anything using async or a Promise, right?

Maybe we can put it under the guides section.

eddyerburgh · 2017-12-12T17:14:08Z

Yes, I think we should add it to the guides section. That would be great if you could write it 🙂

lmiller1990 · 2017-12-14T02:18:02Z

I would like to do this, I will have time after the 19th.

Edit: started here https://github.com/lmiller1990/vue-test-utils/blob/add-async-guide/docs/en/guides/testing-async-components.md

Also, I think we should add something about what to test. A lot of people have problems, when they are testing things using vue test utils that it shouldn't be used for (like testing other people's components).

Not directly related to this library, but I think providing an official library that will become a big part of the ecosystem, some solid guides on how to use it, and not just what it does but what it does not/should not do would be valuable.

I gave a presentation last night about vue-test-utils at v-meetup in Tokyo, and talked to a bunch of people, and one of the main feedback points was "better ways to select things, like calendar inputs".

I think what people are doing is unit testing components that have child components which wrap and , which I don't think should be the job of vue-test-utils (unless of course you are authoring a input wrapper component). The line between unit tests and integration tests is pretty blurred for a lot of people.

eddyerburgh · 2017-12-14T08:23:31Z

Yeah I agree, I'll add it to the list

38elements · 2017-12-17T11:18:44Z

IMHO,
I think it is better that Add docs on what/ how to test is in cookbook.

lmiller1990 · 2017-12-20T08:03:43Z

@38elements I can see your line of thinking. I feel like some test specific guides, with lots of details, would be great to include with vue-test-utils docs, and some more general ones referring to vue-test-utils in the cookbook.

I made PR #282 with a detailed guide about async components, but something more general I think would be great. I'll post in the cookbook repo. Thanks for your input!

robcresswell · 2017-12-26T10:11:48Z

Is it possible to get beta.9 released in the meantime? Having .attributes() broken is a bit of pain 😄

eddyerburgh · 2017-12-27T10:04:19Z

@robcresswell just released

38elements · 2017-12-27T10:46:00Z

Would you please update document page?

robcresswell · 2017-12-27T13:59:25Z

Great work @eddyerburgh !

ghost · 2018-01-18T07:41:22Z

Is there a bug on functional components or I'm missing something?

<template functional> or <script>export default { functional: true }</script> doesn't work.

mount.context can only be used when mounting a functional component

eddyerburgh · 2018-01-18T08:07:51Z

Hi lago, please create a separate issue of this with a minimal reproduction

…

On 18 Jan 2018 07:41, "Iago ♨️" ***@***.***> wrote: Is there a bug on functional components or I'm missing something? <template functional> or <script>export default { functional: true }</script> doesn't work. mount.context can only be used when mounting a functional component — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#246 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMlbW2bGBJ5fnZzmpgTmcF6PUnzLJvAGks5tLvWjgaJpZM4Q8Khu> .

ghost · 2018-10-26T12:28:01Z

Given that the last update on the progress here was almost a year ago, I am interested in the current state of this.

@eddyerburgh Is the checklist in the issue description still accurate and are those the only blockers for the 1.0 release? Are there specific tasks that could need help to speed up the release?

eddyerburgh · 2018-10-26T15:21:00Z

These are the two blockers:

Improve support for extended components
Fix synchronous bugs

The synchronous bugs will be fixed with a small amount of work after the next Vue version is released.

The support for extended components is a major issue, and might require a change to how the library works. Currently we extend components from a Vue constructor that includes added instance proeprties/ stubs. This is fine for component option objects, but Vue.extend is not intended to be used with a constructor function. This has lead to a few bugs that are difficult to fix.

Apart from that there are a few smaller bugs that could be fixed (like #973). I would appreciate help with them, but they aren't blocking from release.

ghost · 2018-10-26T15:25:26Z

Thank you @eddyerburgh, much appreciated! 😃

divasatanica · 2018-11-16T01:57:51Z

Improve support for extended components

I'm now trying to integrate the unit test feature using vue-test-utils into a cli tools.But it was blocking by the issue above because we use typescript and vue-class-component in project.
WISH you guys can fix it. FIGHTING!!

pipopotamasu · 2019-06-28T01:47:36Z

@eddyerburgh I really enjoy using vue-test-utils and am looking forward to release!

However, I am not sure two blockers causes and solutions so I want to clarify them.

Improve support for extended components

Cause

You mean below.

Vue.extend is not intended to be used with a constructor function. This has lead to a few bugs that are difficult to fix.

In my understanding...

// OK: intended usage
const BaseComponent = Vue.extend({
  ~~~~~~ some options ~~~~~~
});

// NG: not intended usage
const ChildComponent = new BaseComponent({
  ~~~~~~ some options ~~~~~~
})

Is it correct?

Solution

You are trying to solve this problem by below issue.
#1084

Fix synchronous bugs

Cause

sync mode of vue-test-utils.

However, you mean ...

The synchronous bugs will be fixed with a small amount of work after the next Vue version is released.

I am not sure what next Vue version(version 3?) brings.
→ I found this PR. You meaned Vue async option!

Solution

below issue.
#1137

Mikilll94 · 2020-01-22T19:23:22Z

When will be the stable version released?

lmiller1990 · 2020-01-22T21:40:11Z

Probably when these are fixed https://github.com/vuejs/vue-test-utils/projects/1. Ideally before Vue 3 comes out. We also need to work on Vue 3 compat.

Is there a specific feature or bugfix you are waiting for? Although in "beta", all the important features and present and many people are successfully using it in production.

telion2 · 2020-04-02T15:00:21Z

The problem is that our customers don't trust packages that are in beta as a general policy. I personally think this is a great project, especially since I dont find a simple way to unit test without it.
It is also mentioned in all the official docs, tutorials etc. so good job there.

So I have 2 questions:

Is solving the mentioned blockers really necessary for a release?
The same as @Mikilll94 "When will be the stable version released?" as I dont see, if the tickets are planned soon, or how long they would take to fix.

I don't intend to pressure anything, rather trying to find out what decision to make.

Mikilll94 · 2020-04-02T15:22:46Z

@telion2
Exactly. For me it is very strange that almost all Vue tutorial, official Vue docs, official Vuetify docs etc. mention this package although it is in beta. Even Vue CLI add this package to the project if we select "unit tests".

Most programmers and companies generally don't trust beta packages and this generally not a good practice to use beta software in production.

lmiller1990 · 2020-04-03T12:15:47Z

I'm surprised your customers are looking at the devDependencies in your projects. That's a good thing, I guess!

Anyway, I agree. I think we can look at a 1.0 after the PRs are merged.

feat: add support of arbitrary mounting point via attachTo option #1492
feat(test-utils): add 'overview' function #1491
WIP: feat/fix: stub out transitions by default #1411 <- not sure how breaking this is

And call it 1.0. We could say 2.x will be Vue 3 support. Let me ask some other contributors to make sure everyone is on board: @JessicaSachs @afontcu and @dobromir-hristov

This reason this was in beta for so long was a variety of reasons:

bugs with sync mode
removal of sync mode
extreme complexity of some features, mainly owning to how we implemented shallowMount (hacking $createElement)

A lot was learned! I hope we can do a better job for 3.x. That said, I thin this lib is in a good enough place for a 1.0 and has helped us understand how people would like to test their components.

1.0 means no more API changes. 2.x will likely have a slightly different API, since Vue 3 internals changed a bit, and some things don't make much sense (createLocalVue and mocks, since attaching to the prototype will be less common).

Anyway, I will get you an answer to this question in the near future (days).

telion2 · 2020-04-03T12:30:57Z

So looking into them, then the first two PRs only need a Review and the last one needs to upgrade vuetify related stuff. Thank you for the information and your time^^.
Really nice project. I like it ;)

afontcu · 2020-04-03T12:42:56Z

I'm OK with shipping v1, this will leave us plenty of time and a stable context for v2.

by the way, #1309 looks like has some breaking changes, so I guess we should decide if tackle it before a proper 1.0 release.

Thanks for moving this forward! 🙌

KajcsaErno · 2020-04-03T13:10:43Z

I can't wait for the release. Thanks for the effort and for creating such a great project.

lmiller1990 · 2020-04-03T14:07:20Z

I can't gauge how important it is to merge #1309. I never use shallowMount - is this an important one to merged up?

If it's too breaking, we may just be better abandoning it. I think VTU has had enough breaking changes at this point.

JessicaSachs · 2020-04-03T22:38:30Z

I think we can omit this from the v1 release. There are two workarounds:

use mount
write your own stub that implements the named slots

lmiller1990 · 2020-04-09T08:41:03Z

Alright, after #1492 let's do v1. I'll follow up on it.

telion2 · 2020-04-20T14:30:19Z

Hi there again.
The last beta release notes: "Note: this is the final beta. Next will be 1.0."
#1492 also looks like its merged.
Is there any holdup or PR that needs to be merged for the release? Thank you in advance!

lmiller1990 · 2020-04-21T00:16:56Z

In VTU next here we made some changes to the API:

when using find(Foo) when finding a component, you will now do findComponent(Foo). find will just be for DOM elements.
destroy is now named unmount (to match Vue 3 API change)
mocks and stubs are "global", so we moved them to a "global" API:

wrapper(Foo, {
  globals: {
    stubs: ...
    mocks: ...
  }
})

As opposed to things like data, which are local to the component.

I'd like to backport, or at least add deprecation warnings for these features before v1. I plan to do that this week sometime.

add a "deprecation" for when people use find with a component. Also support findComponent as an alias to find.
add a globals key (support both mocks and globals.mocks for example). Deprecation message when using mocks (no global key)
deprecation message for destroy. Support unmount as an alias.

The updated VTU next is here.

If you are interested in making these changes, feel free to do so, and we can get things moving more quickly. Not strictly required for v1, but I think it will help people migrating to Vue 3.

lmiller1990 · 2020-04-22T11:51:05Z

Ok, once this RFC is merged in I will add deprecation warnings and release v1.

afontcu · 2020-06-12T22:37:21Z

Looks like this issue can finally be closed!

@lmiller1990 you wrote the first comment back in 2017 – I think you should be the one closing it 😉

lmiller1990 · 2020-06-14T00:21:24Z

Great, closing!

eddyerburgh changed the title ~~To do before releawse~~ To do before release Dec 9, 2017

eddyerburgh added the discussion label Dec 9, 2017

lmiller1990 mentioned this issue Dec 20, 2017

Add async guide #282

Merged

jeremyzahner mentioned this issue Aug 21, 2018

Error with vue-test-utils vuematerial/vue-material#1908

Closed

afontcu mentioned this issue Apr 5, 2020

generate named slots content for stubbed components via shallowMount #1309

Closed

lmiller1990 closed this as completed Jun 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

To do before release #246

To do before release #246

eddyerburgh commented Dec 9, 2017 •

edited by afontcu

Loading

lmiller1990 commented Dec 12, 2017

eddyerburgh commented Dec 12, 2017

lmiller1990 commented Dec 14, 2017 •

edited

Loading

eddyerburgh commented Dec 14, 2017

38elements commented Dec 17, 2017

lmiller1990 commented Dec 20, 2017 •

edited

Loading

robcresswell commented Dec 26, 2017

eddyerburgh commented Dec 27, 2017

38elements commented Dec 27, 2017

robcresswell commented Dec 27, 2017

ghost commented Jan 18, 2018

eddyerburgh commented Jan 18, 2018 via email

ghost commented Oct 26, 2018

eddyerburgh commented Oct 26, 2018 •

edited

Loading

ghost commented Oct 26, 2018

divasatanica commented Nov 16, 2018

pipopotamasu commented Jun 28, 2019 •

edited

Loading

Mikilll94 commented Jan 22, 2020

lmiller1990 commented Jan 22, 2020

telion2 commented Apr 2, 2020

Mikilll94 commented Apr 2, 2020 •

edited

Loading

lmiller1990 commented Apr 3, 2020 •

edited

Loading

telion2 commented Apr 3, 2020 •

edited

Loading

afontcu commented Apr 3, 2020

KajcsaErno commented Apr 3, 2020 •

edited

Loading

lmiller1990 commented Apr 3, 2020

JessicaSachs commented Apr 3, 2020

lmiller1990 commented Apr 9, 2020

telion2 commented Apr 20, 2020

lmiller1990 commented Apr 21, 2020

lmiller1990 commented Apr 22, 2020

afontcu commented Jun 12, 2020

lmiller1990 commented Jun 14, 2020

To do before release #246

To do before release #246

Comments

eddyerburgh commented Dec 9, 2017 • edited by afontcu Loading

lmiller1990 commented Dec 12, 2017

eddyerburgh commented Dec 12, 2017

lmiller1990 commented Dec 14, 2017 • edited Loading

eddyerburgh commented Dec 14, 2017

38elements commented Dec 17, 2017

lmiller1990 commented Dec 20, 2017 • edited Loading

robcresswell commented Dec 26, 2017

eddyerburgh commented Dec 27, 2017

38elements commented Dec 27, 2017

robcresswell commented Dec 27, 2017

ghost commented Jan 18, 2018

eddyerburgh commented Jan 18, 2018 via email

ghost commented Oct 26, 2018

eddyerburgh commented Oct 26, 2018 • edited Loading

ghost commented Oct 26, 2018

divasatanica commented Nov 16, 2018

pipopotamasu commented Jun 28, 2019 • edited Loading

Improve support for extended components

Cause

Solution

Fix synchronous bugs

Cause

Solution

Mikilll94 commented Jan 22, 2020

lmiller1990 commented Jan 22, 2020

telion2 commented Apr 2, 2020

Mikilll94 commented Apr 2, 2020 • edited Loading

lmiller1990 commented Apr 3, 2020 • edited Loading

telion2 commented Apr 3, 2020 • edited Loading

afontcu commented Apr 3, 2020

KajcsaErno commented Apr 3, 2020 • edited Loading

lmiller1990 commented Apr 3, 2020

JessicaSachs commented Apr 3, 2020

lmiller1990 commented Apr 9, 2020

telion2 commented Apr 20, 2020

lmiller1990 commented Apr 21, 2020

lmiller1990 commented Apr 22, 2020

afontcu commented Jun 12, 2020

lmiller1990 commented Jun 14, 2020

eddyerburgh commented Dec 9, 2017 •

edited by afontcu

Loading

lmiller1990 commented Dec 14, 2017 •

edited

Loading

lmiller1990 commented Dec 20, 2017 •

edited

Loading

eddyerburgh commented Oct 26, 2018 •

edited

Loading

pipopotamasu commented Jun 28, 2019 •

edited

Loading

Mikilll94 commented Apr 2, 2020 •

edited

Loading

lmiller1990 commented Apr 3, 2020 •

edited

Loading

telion2 commented Apr 3, 2020 •

edited

Loading

KajcsaErno commented Apr 3, 2020 •

edited

Loading