Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Vue async option for sync mode #1062

Merged
merged 12 commits into from
Feb 2, 2019

Conversation

eddyerburgh
Copy link
Member

@eddyerburgh eddyerburgh commented Dec 10, 2018

@38elements
Copy link
Contributor

It may be necessary to revert #675.

@eddyerburgh
Copy link
Member Author

For the moment we will continue to run sync compat mode (for Vue < 2.5.18), so that change is still
required :)

@38elements
Copy link
Contributor

I think it is necessary to change .circleci/config.yml.

Co-Authored-By: eddyerburgh <[email protected]>
@ryanlitalien
Copy link

Following along, is there anything else that needs to be added for this to get merged? Thanks!

@eddyerburgh eddyerburgh merged commit 4c65dbd into vuejs:dev Feb 2, 2019
@eddyerburgh eddyerburgh deleted the use-vue-async-option branch February 2, 2019 17:33
@agualis
Copy link

agualis commented Feb 2, 2019

💪🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment