fix: no unnecessary extend #1084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grusingh
reviewed
Jan 2, 2019
| @@ -292,29 +292,21 @@ When `sync` is `false`, the Vue component is rendered asynchronously. | |||
|
|
|||
| ## Other options | |||
|
|
|||
| When the options for `mount` and `shallowMount` contain the options other than the mounting options, the component options are overwritten with those using [extends](https://vuejs.org/v2/api/#extends). | |||
| When the options for `mount` and `shallowMount` contain the options other than the mounting options, the options are added used when the Vue instance is initialized. | |||
There was a problem hiding this comment.
When the options for mount and shallowMount contain the options other than the mounting options, the options are added used when the Vue instance is initialized.
| return 'b' | ||
| } | ||
| } | ||
| template: ` |
There was a problem hiding this comment.
This example could be improved to make context more clear.
expect(wrapper.text()).toBe('aBC') would fail?
| @@ -90,8 +90,8 @@ export default function createInstance ( | |||
| // extend component from _Vue to add properties and mixins | |||
| // extend does not work correctly for sub class components in Vue < 2.2 | |||
| const Constructor = typeof component === 'function' | |||
| ? _Vue.extend(component.options).extend(instanceOptions) | |||
| : _Vue.extend(component).extend(instanceOptions) | |||
| ? _Vue.extend(component.options) | |||
|
We're closing this experimental PR for now. The issue is still outstanding, but the API change and approach would break too many tests for our users. We will revisit approaches to solving the initial issue as time goes on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently create a subclass of a component with
extendtwo times, in order to apply instance options. This causes some component options to not have the same own props as they would in production (e.g. #1067).One solution is to stop calling
extendtwice. The solution in this PR means that you can no longer override component options likemethods, orcomputed, using instance options.The instance options would instead be used to instantiate the root Vue instance, so
store,route, can still be passed.This is a large breaking change:
methodsoptionmethods,computed, or other component properties with instance optionsThis PR is a proof of concept as I investigate alternative approaches to fixing #1067.