Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderToString): Remove attachTo from options and print warning on usage #2024

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

freakzlike
Copy link
Collaborator

Prints a warning when using attachTo option on renderToString.

I had to use attachTo?: never because the options are typed with RenderMountingOptions<any> & Record<string, any> (See #1079)

Related to #2023

@freakzlike freakzlike requested a review from cexbrayat April 9, 2023 09:17
@netlify
Copy link

netlify bot commented Apr 9, 2023

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit e989347
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/643282a82e7bf1000722f94a
😎 Deploy Preview https://deploy-preview-2024--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@cexbrayat cexbrayat merged commit 52bb603 into vuejs:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants