Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(renderToString): Remove document usage on SSR render #2023

Merged
merged 1 commit into from
Apr 8, 2023
Merged

fix(renderToString): Remove document usage on SSR render #2023

merged 1 commit into from
Apr 8, 2023

Conversation

freakzlike
Copy link
Collaborator

renderToString unit test now runs in node environment and not jsdom.

The attachTo option has no usage on renderToString. Should we print a warning, when it is used?

Fix #2020

@netlify
Copy link

netlify bot commented Apr 8, 2023 •
edited
Loading

✅ Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 288eb1b
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/643120a84b77b700085c19b7
😎 Deploy Preview https://deploy-preview-2023--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@freakzlike freakzlike requested a review from cexbrayat April 8, 2023 08:08
cexbrayat
cexbrayat approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Maybe we could:

  • add a warning if attachTo is used in renderToString
  • exclude it from the mounting options types for renderToString

@cexbrayat cexbrayat merged commit 0a3b619 into vuejs:main Apr 8, 2023
@freakzlike freakzlike mentioned this pull request Apr 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: document calls should fail during ssr test
2 participants
@freakzlike @cexbrayat