Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderToString): Remove attachTo from options and print warning on usage #2024

Merged
merged 1 commit into from
Apr 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ If you find yourself having to set common App configuration for many of your tes

### attachTo

Specify the node to mount the component on.
Specify the node to mount the component on. This is not available when using `renderToString`.

**Signature:**

Expand Down
31 changes: 19 additions & 12 deletions src/renderToString.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
Prop
} from 'vue'

import { MountingOptions } from './types'
import { RenderMountingOptions } from './types'
import { createInstance } from './createInstance'

// NOTE this should come from `vue`
Expand All @@ -31,7 +31,7 @@ type ComponentMountingOptions<T> = T extends DefineComponent<
any,
any
>
? MountingOptions<
? RenderMountingOptions<
Partial<ExtractDefaultPropTypes<PropsOrPropOptions>> &
Omit<
Readonly<ExtractPropTypes<PropsOrPropOptions>> & PublicProps,
Expand All @@ -40,15 +40,15 @@ type ComponentMountingOptions<T> = T extends DefineComponent<
D
> &
Record<string, any>
: MountingOptions<any>
: RenderMountingOptions<any>

// Class component (without vue-class-component) - no props
export function renderToString<V extends {}>(
originalComponent: {
new (...args: any[]): V
__vccOpts: any
},
options?: MountingOptions<any> & Record<string, any>
options?: RenderMountingOptions<any> & Record<string, any>
): Promise<string>

// Class component (without vue-class-component) - props
Expand All @@ -58,7 +58,7 @@ export function renderToString<V extends {}, P>(
__vccOpts: any
defaultProps?: Record<string, Prop<any>> | string[]
},
options?: MountingOptions<P & PublicProps> & Record<string, any>
options?: RenderMountingOptions<P & PublicProps> & Record<string, any>
): Promise<string>

// Class component - no props
Expand All @@ -67,7 +67,7 @@ export function renderToString<V extends {}>(
new (...args: any[]): V
registerHooks(keys: string[]): void
},
options?: MountingOptions<any> & Record<string, any>
options?: RenderMountingOptions<any> & Record<string, any>
): Promise<string>

// Class component - props
Expand All @@ -77,13 +77,13 @@ export function renderToString<V extends {}, P>(
props(Props: P): any
registerHooks(keys: string[]): void
},
options?: MountingOptions<P & PublicProps> & Record<string, any>
options?: RenderMountingOptions<P & PublicProps> & Record<string, any>
): Promise<string>

// Functional component with emits
export function renderToString<Props extends {}, E extends EmitsOptions = {}>(
originalComponent: FunctionalComponent<Props, E>,
options?: MountingOptions<Props & PublicProps> & Record<string, any>
options?: RenderMountingOptions<Props & PublicProps> & Record<string, any>
): Promise<string>

// Component declared with defineComponent
Expand Down Expand Up @@ -115,7 +115,7 @@ export function renderToString<
Props,
Defaults
>,
options?: MountingOptions<
options?: RenderMountingOptions<
Partial<Defaults> & Omit<Props & PublicProps, keyof Defaults>,
D
> &
Expand Down Expand Up @@ -150,7 +150,7 @@ export function renderToString<
Extends,
EE
>,
options?: MountingOptions<Props & PublicProps, D>
options?: RenderMountingOptions<Props & PublicProps, D>
): Promise<string>

// Component declared with { props: [] }
Expand Down Expand Up @@ -180,7 +180,7 @@ export function renderToString<
EE,
Props
>,
options?: MountingOptions<Props & PublicProps, D>
options?: RenderMountingOptions<Props & PublicProps, D>
): Promise<string>

// Component declared with { props: { ... } }
Expand Down Expand Up @@ -208,10 +208,17 @@ export function renderToString<
Extends,
EE
>,
options?: MountingOptions<ExtractPropTypes<PropsOptions> & PublicProps, D>
options?: RenderMountingOptions<
ExtractPropTypes<PropsOptions> & PublicProps,
D
>
): Promise<string>

export function renderToString(component: any, options?: any): Promise<string> {
if (options?.attachTo) {
console.warn('attachTo option is not available for renderToString')
}

const { app } = createInstance(component, options)
return baseRenderToString(app)
}
28 changes: 23 additions & 5 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type RawProps = VNodeProps & {
[Symbol.iterator]?: never
} & Record<string, any>

export interface MountingOptions<Props, Data = {}> {
interface BaseMountingOptions<Props, Data = {}> {
/**
* Overrides component's default data. Must be a function.
* @see https://test-utils.vuejs.org/api/#data
Expand Down Expand Up @@ -72,18 +72,36 @@ export interface MountingOptions<Props, Data = {}> {
* Provides global mounting options to the component.
*/
global?: GlobalMountOptions
/**
* Automatically stub out all the child components.
* @default false
* @see https://test-utils.vuejs.org/api/#slots
*/
shallow?: boolean
}

/**
* Mounting options for `mount` and `shallowMount`
*/
export interface MountingOptions<Props, Data = {}>
extends BaseMountingOptions<Props, Data> {
/**
* Specify where to mount the component.
* Can be a valid CSS selector, or an Element connected to the document.
* @see https://test-utils.vuejs.org/api/#attachto
*/
attachTo?: HTMLElement | string
}

/**
* Mounting options for `renderToString`
*/
export interface RenderMountingOptions<Props, Data = {}>
extends BaseMountingOptions<Props, Data> {
/**
* Automatically stub out all the child components.
* @default false
* @see https://test-utils.vuejs.org/api/#slots
* Attach to is not available in SSR mode
*/
shallow?: boolean
attachTo?: never
}

export type Stub = boolean | Component | Directive
Expand Down
8 changes: 8 additions & 0 deletions test-dts/renderToString.d-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,11 @@ class ClassComponent extends Vue {
}
}
expectType<Promise<string>>(renderToString(ClassComponent))

// No `attachTo` mounting option
expectError(
renderToString(AppWithProps, {
// @ts-expect-error should not have attachTo mounting option
attachTo: 'body'
})
)
24 changes: 23 additions & 1 deletion tests/renderToString.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* @vitest-environment node
*/

import { describe, it, expect } from 'vitest'
import { describe, it, expect, vi } from 'vitest'
import { defineComponent, onMounted, onServerPrefetch, ref } from 'vue'
import { renderToString } from '../src'

Expand Down Expand Up @@ -61,4 +61,26 @@ describe('renderToString', () => {

expect(contents).toBe('<div>onServerPrefetch</div>')
})

it('returns print warning if `attachTo` option is used', async () => {
const spy = vi.spyOn(console, 'warn').mockReturnValue()

const Component = defineComponent({
template: '<div>foo</div>'
})

expect(
// @ts-expect-error `attachTo` property is not allowed
await renderToString(Component, {
attachTo: 'body'
})
).toBe('<div>foo</div>')

expect(spy).toHaveBeenCalledTimes(1)
expect(spy).toHaveBeenCalledWith(
'attachTo option is not available for renderToString'
)

spy.mockRestore()
})
})