(BKR-1049) Updating require to align with oldest supported PE version. This also matches the merged beaker PR. #89
Conversation
|
Can one of the admins verify this patch? |
|
Failed based on bad travis config it seems... not the change |
|
@cdenneen I have a PR coming your way to touch some of this up |
|
@trevor-vaughan thanks... re-running test now |
|
@cdenneen No problem. I really need this gem so that I can get rid of all my hacky workarounds for the non-PE compatible Beaker. |
|
Huh..it didn't seem to pick up the travis.yml You may need to clear the cache. For some reason Travis CI caches things and I've had issues like this until the cache got completely cleared out. I tested it using 'travish' |
|
@trevor-vaughan no Rakefile |
|
@cdenneen That shouldn't matter, I'm not running Rake. I'm just building the gem. There aren't any spec tests. |
|
@trevor-vaughan Yeah I know I was just reading the error... now it appears rubygems.org is having issues... this build will never pass lol |
|
(╯°□°)╯ ┻━┻ |
|
@trevor-vaughan I added a 2.1 rvm test since this is to port to support oldest PE supported version. |
|
@cdenneen I would just ditch 1.9. I pulled the travis.yml from the main beaker project. |
|
Ugh, Rubygems.org died again 😞 |
|
@trevor-vaughan where is rack specified... need to force that version I think to 1.6.5 in order for 2.1 to pass |
|
@cdenneen Are you sure? The error was |
|
@trevor-vaughan yes Gem::InstallError: rack requires Ruby version >= 2.2.2. the 503 is retryable it seems... but this isn't... so need to force rack below < 2.0.1 when 2.1 of ruby |
|
@cdenneen Weird. I've just set my RVM to 2.1.9 and running |
|
@trevor-vaughan in travis it doesn't seem that way ;) |
|
@cdenneen I guess you'll just have to add the dep to the Gemfile then and call it done. |
|
@trevor-vaughan gemspec or Gemfile? If you wouldn't mind sending another PR might make it quicker (also set my fork up to build with PR so will know if it works before I merge it) |
|
Can someone clear the cache on this and restart the build. My upstream built fine but this is still caching 2.1 vs 2.1.9 |
|
@puppetlabs-jenkins please test |
…. This also matches the merged beaker PR. Syntax Updates * Pinned the upper bound on Ruby * Pinned the rake and rspec dependencies to match Beaker core * Fixed the license to meet SPDX * Added a .travis.yml that builds the gem * Updated the .gitignore file to ignore test garbage * Pin rack version to < 2.2.2
|
@trevor-vaughan thanks everything is good now. I've squashed the PR so all should be good now. |
No description provided.