fix: native webvr #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
fix/native-webvr
branch
2 times, most recently
from
504272b to
2532a19
Compare
brandonocasey
force-pushed
the
fix/native-webvr
branch
from
2532a19 to
977d8cb
Compare
brandonocasey
commented
Jan 17, 2018
| if (!this.vrDisplay) { | ||
| return; | ||
| } | ||
| this.vrDisplay.requestPresent([{source: this.renderedCanvas}]); |
There was a problem hiding this comment.
This is basically all the manager does with the two functions we used to call
brandonocasey
commented
Jan 17, 2018
| @@ -296,31 +304,22 @@ class VR extends Plugin { | |||
| } | |||
|
|
|||
| this.controls3d.update(); | |||
| this.manager.render(this.scene, this.camera); | |||
| this.effect.render(this.scene, this.camera); | |||
There was a problem hiding this comment.
manager did this internally as well
brandonocasey
commented
Jan 17, 2018
| const gamepads = window.navigator.getGamepads(); | ||
| if (window.navigator.getGamepads) { | ||
| // Grab all gamepads | ||
| const gamepads = window.navigator.getGamepads(); |
There was a problem hiding this comment.
This was just a refactor, as it didn't really make sense the way it used to work
misteroneill
approved these changes
Jan 17, 2018
brandonocasey
commented
Jan 17, 2018
| this.controls3d = new VRControls(this.camera); | ||
| } else { | ||
| this.log('no vr displays found going to use OrbitControls'); | ||
| this.controls3d = new OrbitControls(this.camera, this.renderedCanvas); |
There was a problem hiding this comment.
When no VRDisplay is found webvr-polyfill no longer inserts one for native vr implementations. So we have to do our own controls.
brandonocasey
commented
Jan 17, 2018
| return; | ||
| } | ||
| this.vrDisplay.exitPresent(); | ||
| } | ||
|
|
||
| requestAnimationFrame(fn) { | ||
| if (this.vrDisplay) { |
There was a problem hiding this comment.
If we have a vr display we want to request animation from on that instead of the plugin.
|
QA LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Fixes #25
Fixes #18
Fixes #5
Fixes #42