Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable webvr-polyfill controls and implement our own #5

Closed
brandonocasey opened this issue Aug 1, 2017 · 0 comments
Closed

Disable webvr-polyfill controls and implement our own #5

brandonocasey opened this issue Aug 1, 2017 · 0 comments

Comments

@brandonocasey
Copy link
Contributor

Right now this plugin watches window for touch/keyboard/mouse events. Which means that any interaction on the page will move the camera in the 360 video. This is probably not something that should happen, but the only way to fix it is to roll our own controls and listen to events on the video.js player only.

Steps:

  1. Use the window.WebVRConfig from plugin.js to set:
  • MOUSE_KEYBOARD_CONTROLS_DISABLED to true
  • TOUCH_PANNER_DISABLED to true
  1. reimplement mouse/keyboard controls using webvr-polyfill/src/mouse-keyboard-vr-display.js as a base
  2. reimplement touch controls using webvr-polyfill/src/touch-panner.js as a base
  3. Possibly turn of Cardboard VR, and reimplement only in fullscreen?
This was referenced Aug 1, 2017
kevleyski added a commit to kevleyski/videojs-vr that referenced this issue Dec 20, 2022
chore: Swap webvr ro webxr polyfill packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant