Fix/size and controls #6
Conversation
| @@ -1,51 +0,0 @@ | |||
| export default { | |||
There was a problem hiding this comment.
- This was never used
- Most of the comments are out of date
There was a problem hiding this comment.
Did WebVR Boilerplayer not look for it globally? Or is it because the config was being set too late? (See my comment about import ordering)
There was a problem hiding this comment.
It wasn't possible to set because of the file we were using before (webvr-polyfill/build/webvr-polyfill)
src/plugin.js
Outdated
|
|
||
| // this is used to configure webvr-polyfill | ||
| // see https://github.com/googlevr/webvr-polyfill#configuration | ||
| const WebVRConfig = { |
There was a problem hiding this comment.
all import statements are hoisted to the top. We should also write our code that way.
| @@ -1,51 +0,0 @@ | |||
| export default { | |||
There was a problem hiding this comment.
Did WebVR Boilerplayer not look for it globally? Or is it because the config was being set too late? (See my comment about import ordering)
| @@ -239,7 +258,7 @@ const vr = function(options) { | |||
| return; | |||
| } | |||
|
|
|||
| const camera = new THREE.PerspectiveCamera(75, window.innerWidth / window.innerHeight, 1, 1000); | |||
| const camera = new THREE.PerspectiveCamera(75, player.currentWidth() / player.currentHeight(), 1, 1000); | |||
There was a problem hiding this comment.
hopefully, these are the last of them, haha
chore: Swap webvr ro webxr polyfill packages (continue to use webvr p…
webvr-polyfillcontrols and implement our own #5