-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for vive, due to issues with webvr-polyfill #14
Comments
Working here (FF 55.0 64 Bit, Vive, Windows 10) on I've only given it a cursory look but hardware/cardboard VR support is pretty wonky in the current state of this (vjs/videojs-vr) repo. It would be good to have something like this for this repo to be checked off for releases: |
@jbroberg Looks like your example behaves the same way that I saw. I'd have expected to see a cardboard/vr button and then have the video take over the entire viewing area. What I currently see is that if I tell the vive to show the desktop, I can then see the video in the window but it does track the headset. So, maybe it's just an expectation problem. |
@gkatsev - weird. It's working great for me. Is your SteamVR set up correctly? Are you running the 64-Bit version of Firefox 55? |
So, @brandonocasey found this matching issue which is the root cause: borismus/webvr-boilerplate#170 Basically, If we pin to webvr-polyfill 0.9.23 we should be OK for now. I'll also update the issues and maybe look into a PR to fix it upstream. |
If you run the polyfill when native VR is available, you won't be able to put the player into VR mode properly. This should fix borismus/webvr-boilerplate#170 and videojs/videojs-vr#14
Made a PR against the polyfill: immersive-web/webvr-polyfill#276 |
We will have to revert #21 when this is fixed |
If you run the polyfill when native VR is available, you won't be able to put the player into VR mode properly. This should fix borismus/webvr-boilerplate#170 and videojs/videojs-vr#14
My PR was merged into the webvr-polyfill, hopefully we'll be able to update once it gets released. |
See #35 for fix. |
chore: Swap webvr for webxr polyfill packages (PR fix ups - adding 180 top/bottom)
At least in Firefox 55 on windows 10 with HTC Vive, the VRDisplay is rejected because it isn't an instance of a specified type: https://github.com/MetaCDN/webvr-boilerplate/blob/master/src/webvr-manager.js#L136-L144
The text was updated successfully, but these errors were encountered: