Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for vive, due to issues with webvr-polyfill #14

Closed
gkatsev opened this issue Aug 9, 2017 · 8 comments
Closed

No support for vive, due to issues with webvr-polyfill #14

gkatsev opened this issue Aug 9, 2017 · 8 comments

Comments

@gkatsev
Copy link
Member

gkatsev commented Aug 9, 2017

At least in Firefox 55 on windows 10 with HTC Vive, the VRDisplay is rejected because it isn't an instance of a specified type: https://github.com/MetaCDN/webvr-boilerplate/blob/master/src/webvr-manager.js#L136-L144

@jbroberg
Copy link
Contributor

Working here (FF 55.0 64 Bit, Vive, Windows 10) on
https://github.com/MetaCDN/videojs-vr
https://videojs-vr.s3.amazonaws.com/latest/example.html

I've only given it a cursory look but hardware/cardboard VR support is pretty wonky in the current state of this (vjs/videojs-vr) repo. It would be good to have something like this for this repo to be checked off for releases:
https://github.com/MetaCDN/videojs-vr/wiki/Browser-Compatibility

@gkatsev
Copy link
Member Author

gkatsev commented Aug 11, 2017

@jbroberg Looks like your example behaves the same way that I saw. I'd have expected to see a cardboard/vr button and then have the video take over the entire viewing area. What I currently see is that if I tell the vive to show the desktop, I can then see the video in the window but it does track the headset. So, maybe it's just an expectation problem.

@jbroberg
Copy link
Contributor

@gkatsev - weird. It's working great for me. Is your SteamVR set up correctly? Are you running the 64-Bit version of Firefox 55?

https://videojs-vr.s3.amazonaws.com/latest/example.html

@gkatsev
Copy link
Member Author

gkatsev commented Aug 17, 2017

So, @brandonocasey found this matching issue which is the root cause: borismus/webvr-boilerplate#170
https://github.com/googlevr/webvr-polyfill/blob/5f8693a9053ee1dea425e96d14cd1f2bef7a284c/src/webvr-polyfill.js#L39-L40

Basically, enablePolyfill runs when it shouldn't. Happened due to this commit: immersive-web/webvr-polyfill@1bf23ee

If we pin to webvr-polyfill 0.9.23 we should be OK for now. I'll also update the issues and maybe look into a PR to fix it upstream.

gkatsev added a commit to gkatsev/webvr-polyfill that referenced this issue Aug 17, 2017
If you run the polyfill when native VR is available, you won't be able to put the player into VR mode properly. This should fix borismus/webvr-boilerplate#170 and videojs/videojs-vr#14
@gkatsev
Copy link
Member Author

gkatsev commented Aug 17, 2017

Made a PR against the polyfill: immersive-web/webvr-polyfill#276

@brandonocasey
Copy link
Contributor

We will have to revert #21 when this is fixed

@brandonocasey brandonocasey changed the title No support for vive No support for vive, due to issues with webvr-polyfill Sep 7, 2017
jsantell pushed a commit to immersive-web/webvr-polyfill that referenced this issue Sep 12, 2017
If you run the polyfill when native VR is available, you won't be able to put the player into VR mode properly. This should fix borismus/webvr-boilerplate#170 and videojs/videojs-vr#14
@gkatsev
Copy link
Member Author

gkatsev commented Sep 12, 2017

My PR was merged into the webvr-polyfill, hopefully we'll be able to update once it gets released.

@jbroberg
Copy link
Contributor

jbroberg commented Oct 3, 2017

See #35 for fix.

@jbroberg jbroberg mentioned this issue Oct 3, 2017
mister-ben pushed a commit to mister-ben/videojs-vr that referenced this issue Dec 4, 2023
chore: Swap webvr for webxr polyfill packages (PR fix ups - adding 180 top/bottom)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants