Vive, Rift HMDs not being recognized in getDeviceByType_()

[beaucronin]

With both Vive and Rift, on both Chromium 56.0.2902.0 and Firefox Nightly, the getDeviceByType_() function is not seeing the HMD and is returning null.

The problem seems to be that the instanceof check in this line is not returning true https://github.com/borismus/webvr-boilerplate/blob/master/src/webvr-manager.js#L139

This is happening even though there is indeed a VRDisplay object available (either Vive or Rift), and if I encourage the check to return true (by inspecting the VRDisplay.displayName property, for example), everything works fine. I have used a breakpoint to inspect the VRDisplay object, and to my eye it looks fine - I have no idea why the instanceof check is returning false.

For reference, my current patch for that line (which works with both systems, on both browsers), is this monstrosity:

if (displays[i] instanceof type || displays[i].displayName == "HTC Vive DVT" || displays[i].displayName.startsWith("Oculus")) {

[alfa256]

I'm experiencing the same issue, it only seems to work on chromium vr build for android.

[buesing]

I can also reproduce this with the latest chromium build on windows (56.0.2910.0)

[gkatsev]

I think the root cause is that enablePolyfill from webvr-polyfill runs even when it shouldn't.
https://github.com/googlevr/webvr-polyfill/blob/5f8693a9053ee1dea425e96d14cd1f2bef7a284c/src/webvr-polyfill.js#L39-L40
Seems to be caused by this commit: immersive-web/webvr-polyfill@7908ac4