master/TBA remaining issues

[brandonocasey]

issues

• fix: delay first audio appends when we have not done a video append #545 Video freezes at the start of playback, but audio starts (advanced fmp4 bipbop)
• fix: delay first audio appends when we have not done a video append #545 buffers after starting playback, unless you hit play (advanced fmp4 bipbop)
• feat: Add handlePartialData as a top level option #532 Add a way to configure handlePartialData via VHS options
• fix: do not always set ended_ to false on sourceopen #512 Ended not firing
• fix: Return the correct buffer for each segmentloader #542 Not clearing out source buffer as we play, causes us to run out of memory 16-17 mins of playback.
• fix: fmp4 playback #519 Various fmp4 playback improvements
• fix: Alternative audio with handlePartialData #558 Alt audio with handlePartialData set to true
• fix: Prevent double 608 captions on rendition change #530 Multiple of the same captions
• Feat/fmp4 ts support #556 Get mixed fmp4 ts playlists working
• fix: Use pts value for timingInfo probes (#616/#660 from 1.x) #624 (comment) Fix is here fix: always calculate the earliest allowed dts using baseMediaDecodeTime mux.js#317
• TS segment with SPS/PPS in the end of access units when using HLS can't be played. video.js#6282 unsupported

mux.js

• Transmux Pre Append and LHLS - AKA Support for Partial Appends mux.js#264 TBA and partial append work used by all of this
• feat: parse mp4 tracks mux.js#270 parse mp4 tracks, used by fix: fmp4 playback #519
• fix: Fire trackinfo for audio only transmuxers mux.js#277 Fire trackinfo for audio only streams, used by fix: Alternative audio with handlePartialData #558
• Feat: change remux after initial creation mux.js#276 Fixes fmp4/ts playlists, used by Feat/fmp4 ts support #556

improvements

• feat: better demo page #533 Better demo page
• fix: issues with the demo in ie11 and firefox #544 Add back in type specifier for url

Pushed Back

• fmp4 and ts with handlePartialData. The issue here is that during handlePartialData with muxed content browsers expect the initSegment that we generate to contain the same tracks as they did previously. For non partial we can set the Coalesce stream to remux, which makes it so that the initSegment has both tracks. For the partial transmuxer it is much harder because we don't have a Coalesce stream.
  • We can add a Coalesce stream and check if we are generating content that should have audio and video and then just mock out a fake track for what we will generate later.
  • We may have to wait for audio data before we can emit any data so that we can emit an initSegment with both tracks.

testing

• Test ABR with handlePartialData

[ldayananda]

are these two handled by the same PR?

• Video freezes at the start of playback, but audio starts (advanced fmp4 bipbop)
• buffers after starting playback, unless you hit play (advanced fmp4 bipbop)

[brandonocasey]

yes

[mparisi76]

I thought someone said #425 would be included in this release, but I don't see it in the list above. Any plans to address that issue?

[gkatsev]

We haven't had a change to look at #425, it would've potentially been fixed by this but definitely possible it hasn't. Is that still a problem happening in master?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[brandonocasey]

It seems like #425 is fixed in master. I added a manifest to test the file with http://d2zihajmogu5jn.cloudfront.net/bad-pmt/index.m3u8 although it's possible I did not create an accurate reproduction.

[brandonocasey]

#624 (comment) is fixed by videojs/mux.js#317

[danrossi]

I tested this with wowza but not sure if its requesting the sub fragments properly. how can I test it to confirm it's requesting properly ?. The LHLS urls are working at least with these updates.

[gkatsev]

Unfortunately, we do not have full support for Apple's or the open LHLS specs.

[danrossi]

So it's not fully working yet apart from requesting fragments ? It's playing but don't know if its requesting properly. What requests are we expecting to see ?

[gkatsev]

The reason this is called LHLS is because it was done in service to getting support for low latency streaming, such as being able to download and use parts of segments. Yes, it's confusing, but it kind of stuck. However, actual support for the specs isn't included yet. That means we don't handle anything related to the parts stuff in Apple's LHLS or the prefetch tags from the open source spec.
Both of those would be treated as just regular HLS streams currently.

[danrossi]

OK. Well it's requesting LHLS wowza streams fine, but we should expect partial requests then when it's working.

[gkatsev]

• port fix: put devicePixelRatio behind useDevicePixelRatio option #785 to master fix: put devicePixelRatio behind useDevicePixelRatio option #844
• verify that we can replay a video inside a PiP need to port 1a4fc1e to master revert: fix: Use middleware and a wrapped function for seeking instea… #856

[gkatsev]

Closing as complete. There's just the two PRs in the 2.0 milestone left, and we can use the milestone to track any other work.